Skip to content

Change sort order for customer group options #18117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
magento-engcom-team merged 2 commits into from
Sep 25, 2018
Merged

Change sort order for customer group options #18117

magento-engcom-team merged 2 commits into from
Sep 25, 2018

Conversation

@dmytro-ch
Copy link
Contributor

@dmytro-ch dmytro-ch commented Sep 18, 2018

Description

Change sort order for customer group options. The customer groups will be listed alphabetically.

Fixed Issues

  1. Wrong sort order for customer groups in customer grid filter #18101: Wrong sort order for customer groups in customer grid filter

Manual testing scenarios

  1. imagine you've 50 customer groups (not only 3 default)
  2. go to admin customer grid and filter by group

Expected result

  1. customer groups are listed alphabetically

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmytro-ch dmytro-ch requested a review from rogyar September 18, 2018 12:48
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Component: Customer Release Line: 2.3 labels Sep 18, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 18, 2018

Hi @dmytro-ch. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Sep 19, 2018
@rogyar
Copy link
Contributor

rogyar commented Sep 19, 2018

The solution works great. I've just added some minor code style fixes

@slavvka slavvka mentioned this pull request Sep 25, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit ed99490 into magento:2.3-develop Sep 25, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 25, 2018
ENGCOM-3014: Change sort order for customer group options #18117
6539c5f
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 25, 2018

Hi @dmytro-ch. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@dmytro-ch dmytro-ch mentioned this pull request Sep 27, 2018
Merged
4 tasks
sreichel added a commit to sreichel/magento2 that referenced this pull request Oct 17, 2018
@sreichel
Remove unnecessary class import, see magento#18117
10d4a59
@sreichel sreichel mentioned this pull request Oct 17, 2018
Merged
4 tasks
magento-engcom-team added a commit that referenced this pull request Oct 25, 2018
@magento-engcom-team
ENGCOM-3212: Remove unnecessary class import, see #18117 #18671
67da74f 
 - Merge Pull Request #18671 from sreichel/magento2:develop/18117-cs
 - Merged commits:
   1. 10d4a59
magento-engcom-team pushed a commit that referenced this pull request Oct 25, 2018
ENGCOM-3212: Remove unnecessary class import, see #18117 #18671
d587d3c
magento-engcom-team pushed a commit that referenced this pull request Oct 25, 2018
🔃 [EngCom] Public Pull Requests - 2.3-develop
5916c5a 
Accepted Public Pull Requests:
 - #18708: Cover \Magento\GiftMessage\Observer\SalesEventQuoteMerge with Unit test (by @vasilii-b)
 - #18733: Correct a typo in the reference to ISO language codes (by @mage2pratik)
 - #18723: Updated links in README (by @StrikerRUS)
 - #18694: Added Unit Test for WindowsSmtpConfig Plugin (by @vasilii-b)
 - #18707: Cover \Magento\Email\Model\Template\SenderResolver class with Unit test (by @vasilii-b)
 - #18710: [Elasticsearch] Covering the CategoryProductIndexer by Unit Test (by @eduard13)
 - #18284: save the custom option price when it is 0 (by @amatanovic)
 - #18702: [Forwardport][2.3] of MAGETWO-93818: Magnifier function does not disappear after mouse-off the image from the bottom (by @gwharton)
 - #17300: Add ReadFactory and WriteFactory to Magento's public API (by @navarr)
 - #17296: Add Value to Magento Framework's public API (by @navarr)
 - #18671: Remove unnecessary class import, see #18117 (by @sreichel)
 - #18667: Fixed class name issue in comment (by @gelanivishal)
 - #18627: Fixed incorrect datepicker icon position in admin panel (by @rogyar)
 - #18614: Braintree Paypal Review: check if variable is array when validating request data (by @deninchoo)
 - #18488: Fix issue with unexpected changing of subscription status after customer saving (by @alexeya-ven)
 - #18333: Support of error pages behind a load balancer that serves HTTPS  (by @stkams)
 - #18080: Add checkout_cart_product_add_before event #17830 (by @leandro-rosa)


Fixed GitHub Issues:
 - #2686: 500 Internal Server Error upon clicking SAVE button of product record adding/editing (reported by @protodevsystems) has been fixed in #18733 by @mage2pratik in 2.3-develop branch
   Related commits:
     1. a4b5cc1

 - #17616: Importer fails when updating an existing product with custom options (reported by @simonworkhouse) has been fixed in #18284 by @amatanovic in 2.3-develop branch
   Related commits:
     1. 4c76f9a
     2. 74ca77c

 - #15035: [2.2.4] Gallery Magnifier hover event does not always cancel magnifier when mouse leaves gallery (reported by @gwharton) has been fixed in #18702 by @gwharton in 2.3-develop branch
   Related commits:
     1. 031d8ec
     2. 4b76ffd

 - #18605: Calendar Icon is displaced at the Backend (reported by @larsroettig) has been fixed in #18627 by @rogyar in 2.3-develop branch
   Related commits:
     1. 3f0e9a4

 - #17830: Add checkout_cart_product_add_before event (reported by @peterjaap) has been fixed in #18080 by @leandro-rosa in 2.3-develop branch
   Related commits:
     1. 7b728b1
     2. f9389ad
     3. fef2205
     4. 0de795a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rogyar rogyar Awaiting requested review from rogyar

Assignees

@rogyar rogyar

Labels

Award: bug fix Component: Customer Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@dmytro-ch @magento-engcom-team @rogyar @sreichel