feat: add subscriber limits to WebSocketPublisher#63
Merged
Conversation
sieniven
reviewed
Jan 21, 2026
sieniven
reviewed
Jan 22, 2026
sieniven
reviewed
Jan 22, 2026
limyeechern
force-pushed
the
lucas/add-ws-limit
branch
from
737c860 to
76befd0
Compare
limyeechern
force-pushed
the
lucas/add-ws-limit
branch
from
76befd0 to
3081483
Compare
sieniven
reviewed
Jan 22, 2026
sieniven
reviewed
Jan 22, 2026
sieniven
reviewed
Jan 22, 2026
sieniven
approved these changes
Jan 22, 2026
sieniven
pushed a commit
that referenced
this pull request
Jan 22, 2026
* feat: add subscriber limit for websocket connections * fix: change args * fix: add return error message * fix: change log level & make lint * chore: update imports * chore: increment after check, change log level * fix: change subscriber limit to u16 from Option * chore: inline code * chore: update comments
sieniven
added a commit
that referenced
this pull request
Feb 5, 2026
…#373) * feat: add subscriber limits to WebSocketPublisher (#63) * feat: add subscriber limit for websocket connections * fix: change args * fix: add return error message * fix: change log level & make lint * chore: update imports * chore: increment after check, change log level * fix: change subscriber limit to u16 from Option * chore: inline code * chore: update comments * Revert default behaviour, dont set default limit on wspub subscriber count --------- Co-authored-by: lucas <66681646+limyeechern@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Add configurable limit to number of subscribers for WebSocketPublisher. Rejects the connection with error message if the connection limit exceeds.
💡 Motivation and Context
Additional layer of restriction to protect service from being flooded with subscription request
✅ I have completed the following steps:
make lintmake test