fix(wspub): add flashblocks payload subscriber count limit#373
Merged
avalonche merged 2 commits intoflashbots:mainfrom Feb 4, 2026
Merged
fix(wspub): add flashblocks payload subscriber count limit#373avalonche merged 2 commits intoflashbots:mainfrom
avalonche merged 2 commits intoflashbots:mainfrom
Conversation
* feat: add subscriber limit for websocket connections * fix: change args * fix: add return error message * fix: change log level & make lint * chore: update imports * chore: increment after check, change log level * fix: change subscriber limit to u16 from Option * chore: inline code * chore: update comments
sieniven
requested review from
0x416e746f6e,
SozinM,
avalonche and
karim-agha
as code owners
sieniven
changed the title
avalonche
reviewed
Jan 27, 2026
| #[arg( | ||
| long = "flashblocks.ws-subscriber-limit", | ||
| env = "FLASHBLOCK_WS_SUBSCRIBER_LIMIT", | ||
| default_value = "256" |
Collaborator
There was a problem hiding this comment.
could the default be no limit? this way it would be a backwards compatible change
Contributor
Author
There was a problem hiding this comment.
Hmm, the default was added here because it helps protect the node against perhaps an attack vector (like ddos)? Will it be better if we tune the default value up instead?
Contributor
Author
There was a problem hiding this comment.
@avalonche hey! eba797b resolves the issue by switching the sub limit to an option instead, and removes the default limit size.
Collaborator
There was a problem hiding this comment.
@sieniven op-rbuilder flashblocks websocket should be accesses only by rollup-boosts
avalonche
approved these changes
Feb 4, 2026
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Adds a maximum number of websocket subscriber limit on the wspub server.
✅ I have completed the following steps:
make lintmake test