Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using discovery url #146

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

sameh0
Copy link
Contributor

@sameh0 sameh0 commented Jul 31, 2023

Enhancements in OAuth2Client & OpenIdConfigurationRequest

  • Properly utilize the passed discovery URL in OAuth2Client.swift. Previously, it was only being set but not used.

  • Eliminated redundant logic: The logic to append .well-known to the URL was duplicated in both OpenIdConfigurationRequest and the OAuth2Client.swift initializer. This has now been streamlined, removing the redundancy from OpenIdConfigurationRequest.


@mikenachbaur-okta
Copy link
Contributor

Thank you for your pull request. This seems like a very straightforward fix to an obvious bug. I've kicked off the CI process for this change, and if none of the tests fail, I should be able to merge and release it shortly.

@mikenachbaur-okta mikenachbaur-okta changed the base branch from master to man-contributions August 1, 2023 19:48
@mikenachbaur-okta mikenachbaur-okta merged commit e88011c into okta:man-contributions Aug 1, 2023
4 of 10 checks passed
mikenachbaur-okta added a commit that referenced this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants