Using discovery url #146
Merged
Using discovery url #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request. This seems like a very straightforward fix to an obvious bug. I've kicked off the CI process for this change, and if none of the tests fail, I should be able to merge and release it shortly. |
mikenachbaur-okta
merged commit e88011c
into
okta:man-contributions
4 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancements in OAuth2Client & OpenIdConfigurationRequest
Properly utilize the passed discovery URL in
OAuth2Client.swift. Previously, it was only being set but not used.Eliminated redundant logic: The logic to append
.well-knownto the URL was duplicated in bothOpenIdConfigurationRequestand theOAuth2Client.swiftinitializer. This has now been streamlined, removing the redundancy fromOpenIdConfigurationRequest.