Obvious Fix: Change minimum iOS version from 15 to 13 where possible #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting this. The minimum was set to iOS 15 due to issues with Xcode 13 throwing compiler errors when Swift Concurrency features were used while targeting older iOS versions. These problems seem to have been fixed in Xcode 14, so we can certainly go ahead with this. Since this SDK supports platforms other than iOS (tvOS, watchOS, and macOS), we'd need to ensure the supported versions match all available platforms though. @sebastiangrail would you be able to update the supported versions in those @available attributes to support tvOS 13, watchOS 6, and macOS 10.15? |
|
@mikenachbaur-okta Done. Note that the build for tvOS and watchOS is broken for unrelated reasons (tested on Xcode 14.3.1). |
mikenachbaur-okta
merged commit f391358
into
okta:man-contributions
4 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All async/await APIs are currently only available for iOS 15 but the minimum requirement for async/await is iOS 13. This PR changes the minimum iOS version from 15 to 13 where possible.