Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 171 jm scrub auth params #178

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

jmelberg-okta
Copy link
Contributor

Due to a bug in our implementation of #171 - silent token renewal or getWithoutPrompt calls would throw errors.

Until there is a better story around ignoring/fixing null values, this change will be reverted.

@haishengwu-okta
Copy link
Contributor

🤦‍♂️

@jmelberg-okta jmelberg-okta merged commit ab4c769 into master Nov 12, 2018
@jmelberg-okta jmelberg-okta deleted the revert-171-jm-scrub-auth-params branch November 12, 2018 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants