bug: Removes null/undefined scrubbing from authorize requests

okta · Nov 12, 2018 · ab4c769 · ab4c769
1 parent 4e162b1
commit ab4c769
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 114 deletions.
diff --git a/lib/token.js b/lib/token.js
@@ -208,9 +208,8 @@ function handleOAuthResponse(sdk, oauthParams, res, urls) {
   });
 }
 
-function getDefaultOAuthParams(sdk, options) {
-  var oauthOptions = util.clone(options) || {};
-  oauthOptions = util.removeNils(oauthOptions);
+function getDefaultOAuthParams(sdk, oauthOptions) {
+  oauthOptions = util.clone(oauthOptions) || {};
 
   var defaults = {
     clientId: sdk.options.clientId,

diff --git a/test/spec/token.js b/test/spec/token.js
@@ -32,39 +32,6 @@ describe('token.decode', function() {
 });
 
 describe('token.getWithoutPrompt', function() {
-  it('uses default authorization parameters if undefined/null values are provided \
-    when requesting an id_token using a sessionToken', function(done) {
-    return oauthUtil.setupFrame({
-      oktaAuthArgs: {
-        issuer: 'https://auth-js-test.okta.com',
-        clientId: 'NPSfOkH5eZrTy8PMDlvx',
-        redirectUri: 'https://example.com/redirect',
-        scopes: null,
-        responseType: undefined
-      },
-      getWithoutPromptArgs: {
-        sessionToken: 'testSessionToken'
-      },
-      postMessageSrc: {
-        baseUri: 'https://auth-js-test.okta.com/oauth2/v1/authorize',
-        queryParams: {
-          'client_id': 'NPSfOkH5eZrTy8PMDlvx',
-          'redirect_uri': 'https://example.com/redirect',
-          'response_type': 'id_token',
-          'response_mode': 'okta_post_message',
-          'state': oauthUtil.mockedState,
-          'nonce': oauthUtil.mockedNonce,
-          'scope': 'openid email',
-          'prompt': 'none',
-          'sessionToken': 'testSessionToken'
-        }
-      }
-    })
-    .fin(function() {
-      done();
-    });
-  });
-
   it('returns id_token using sessionToken', function(done) {
     return oauthUtil.setupFrame({
       oktaAuthArgs: {
@@ -605,39 +572,6 @@ describe('token.getWithoutPrompt', function() {
 });
 
 describe('token.getWithPopup', function() {
-  it('uses default authorization parameters if undefined/null values are provided \
-    when requesting an id_token using idp', function(done) {
-    return oauthUtil.setupPopup({
-      oktaAuthArgs: {
-        issuer: 'https://auth-js-test.okta.com',
-        clientId: 'NPSfOkH5eZrTy8PMDlvx',
-        redirectUri: 'https://example.com/redirect',
-        scopes: null,
-        responseType: undefined
-      },
-      getWithPopupArgs: {
-        idp: 'testIdp'
-      },
-      postMessageSrc: {
-        baseUri: 'https://auth-js-test.okta.com/oauth2/v1/authorize',
-        queryParams: {
-          'client_id': 'NPSfOkH5eZrTy8PMDlvx',
-          'redirect_uri': 'https://example.com/redirect',
-          'response_type': 'id_token',
-          'response_mode': 'okta_post_message',
-          'display': 'popup',
-          'state': oauthUtil.mockedState,
-          'nonce': oauthUtil.mockedNonce,
-          'scope': 'openid email',
-          'idp': 'testIdp'
-        }
-      }
-    })
-    .fin(function() {
-      done();
-    });
-  });
-
   it('returns id_token using idp', function(done) {
       return oauthUtil.setupPopup({
         oktaAuthArgs: {
@@ -1001,51 +935,6 @@ describe('token.getWithPopup', function() {
 });
 
 describe('token.getWithRedirect', function() {
-  it('uses default authorization parameters if undefined/null values are provided \
-    when minting an id_token using sessionToken', function() {
-    oauthUtil.setupRedirect({
-      getWithRedirectArgs: {
-        sessionToken: 'testToken',
-        scopes: null,
-        responseType: undefined
-      },
-      expectedCookies: [
-        [
-          'okta-oauth-redirect-params',
-          JSON.stringify({
-            responseType: 'id_token',
-            state: 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
-            nonce: 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
-            scopes: ['openid', 'email'],
-            clientId: 'NPSfOkH5eZrTy8PMDlvx',
-            urls: {
-              issuer: 'https://auth-js-test.okta.com',
-              authorizeUrl: 'https://auth-js-test.okta.com/oauth2/v1/authorize',
-              userinfoUrl: 'https://auth-js-test.okta.com/oauth2/v1/userinfo'
-            },
-            ignoreSignature: false
-          })
-        ],
-        [
-          'okta-oauth-nonce',
-          'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
-        ],
-        [
-          'okta-oauth-state',
-          'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
-        ]
-      ],
-      expectedRedirectUrl: 'https://auth-js-test.okta.com/oauth2/v1/authorize?' +
-                            'client_id=NPSfOkH5eZrTy8PMDlvx&' +
-                            'redirect_uri=https%3A%2F%2Fexample.com%2Fredirect&' +
-                            'response_type=id_token&' +
-                            'response_mode=fragment&' +
-                            'state=aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa&' +
-                            'nonce=aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa&' +
-                            'sessionToken=testToken&' +
-                            'scope=openid%20email'
-    });
-  });
   it('sets authorize url and cookie for id_token using sessionToken', function() {
     oauthUtil.setupRedirect({
       getWithRedirectArgs: {