Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /v2 suffix to import #47

Merged
merged 1 commit into from
May 9, 2019
Merged

Add /v2 suffix to import #47

merged 1 commit into from
May 9, 2019

Conversation

peterbourgon
Copy link
Member

If we opt-in to modules with a non-v0 or v1 version, we have to explicitly append /vX to the import path whenever we import. This is infuriating, but I guess I lost that battle.

If we opt-in to modules with a non-v0 or v1 version, we have to
explicitly append /vX to the import path whenever we import.

This is infuriating.
@peterbourgon
Copy link
Member Author

Tangentially related to #43.

@peterbourgon peterbourgon merged commit be3bccf into master May 9, 2019
@peterbourgon peterbourgon deleted the modules-errata branch May 9, 2019 10:02
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.938% when pulling 041c8fa on modules-errata into 32a8f2e on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.938% when pulling 041c8fa on modules-errata into 32a8f2e on master.

@javasgl
Copy link

javasgl commented Nov 28, 2019

WTF. It's broken when use dep

Could not introduce github.com/oklog/[email protected], as its subpackage github.com/oklog/ulid/v2 is missing

@peterbourgon
Copy link
Member Author

peterbourgon commented Nov 28, 2019

Yep, using the tags approach for post-1.0.0 versioning, which we are doing, requires modules. This isn't going to change on our side, so I'd suggest switching to modules on your side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants