Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New release with go.modules? #43

Closed
im-kulikov opened this issue Apr 2, 2019 · 7 comments
Closed

New release with go.modules? #43

im-kulikov opened this issue Apr 2, 2019 · 7 comments

Comments

@im-kulikov
Copy link
Contributor

im-kulikov commented Apr 2, 2019 •
edited
Loading

Is it possible to make a new release with go.modules support?

cc: @tsenart / @peterbourgon
@vtolstov
Copy link

vtolstov commented Apr 2, 2019

yes, will be nice!

@peterbourgon
Copy link
Member

Note that the first release after adding Go modules support should bump the major version number.

@im-kulikov
Copy link
Contributor Author

Not sure

@ronnylt
Copy link

ronnylt commented May 7, 2019

After upgrading to the new major version that has support for Go modules, I am getting this error:

go: github.com/oklog/ulid/[email protected]: go.mod has non-.../v2 module path "github.com/oklog/ulid" (and .../v2/go.mod does not exist) at revision v2.0.0 go: error loading module requirements

@peterbourgon
Copy link
Member

Oh yeah, I need to put v2 in the go.mod, one second.

@peterbourgon
Copy link
Member

@ronnylt Can you try with latest v2.0.1?

@ronnylt
Copy link

ronnylt commented May 7, 2019

@peterbourgon it's working now! Thanks.

@peterbourgon peterbourgon mentioned this issue May 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ronnylt @peterbourgon @vtolstov @im-kulikov