Add lint checks to scan for un-imported files and unused packages #10390

rithviknishad · 2025-02-04T13:21:05Z

Proposed Changes

Resolves Update lint check CI to scan for unused files / dependencies / etc. #10347
Add lint checks (to CI and pre-commit hook) to scan for un-imported files and unused packages

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Request for Peer Reviews

Summary by CodeRabbit

Chores
- Improved the quality assurance workflow by adding an extra linting step for unused imports.
- Introduced new configuration settings to refine the import analysis process.
- Updated development scripts and dependencies to integrate the unimported utility for managing unused imports.

coderabbitai · 2025-02-04T13:21:15Z

Warning

Rate limit exceeded

@rithviknishad has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 37 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between b73766d and 8724131.

📒 Files selected for processing (1)

.unimportedrc.json (1 hunks)

Walkthrough

This pull request integrates the unimported tool into the linting process. A new GitHub Actions step is added to execute the unused import check following the existing lint step. A dedicated configuration file is introduced to define ignore patterns and entry points for the analysis. Additionally, the project’s package configuration is updated to include the necessary script, dependency, and lint-staged integration. Overall, this change enhances the codebase’s checks by automatically detecting unused files, dependencies, and imports during CI.

Changes

File(s)	Change Summary
`.github/workflows/linter.yml`	Added a new step "Run unimported" to execute `npm run unimported` immediately after the existing lint step.
`.unimportedrc.json`	Updated configuration file for `unimported` with new entries in `ignoreUnimported`, `ignoreUnused`, `ignoreUnresolved`, and `entry`.
`package.json`	Added the `"unimported"` script and dependency (`^1.31.0`) as well as configured `lint-staged` to run the `unimported` command on staged files.

Assessment against linked issues

Objective	Addressed	Explanation
Update lint check CI to scan for unused files/dependencies/etc. (#10347)	✅

Possibly related PRs

Enhance Vite configuration and browser support script #10040: Enhances ESLint integration in the Vite configuration with a similar focus on linting improvements.
Cleanup: Remove unnecessary GitHub workflows #10342: Involves modifications to the GitHub Actions linting workflow that align with the changes introduced in this PR.

Suggested labels

needs testing, P1

Suggested reviewers

khavinshankar
bodhish

Poem

I’m a rabbit on a coding spree,
Hopping through changes so merrily,
Unused imports vanish without a trace,
Linting steps keep up the pace,
Carrots of clean code celebrate with glee!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-02-04T13:21:25Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`8724131`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67a216b3f0bdad0008399e3b
😎 Deploy Preview	https://deploy-preview-10390--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cloudflare-workers-and-pages · 2025-02-04T13:27:07Z

Deploying care-fe with Cloudflare Pages

Latest commit:	`8724131`
Status:	✅ Deploy successful!
Preview URL:	https://2b0b44e2.care-fe.pages.dev
Branch Preview URL:	https://rithviknishad-chore-lint-che.care-fe.pages.dev

View logs

cypress · 2025-02-04T13:28:57Z

CARE Run #4604

Run Properties: Passed #4604 • 8724131343: Add lint checks to scan for un-imported files and unused packages

Project	`CARE`
Branch Review	`rithviknishad/chore/lint-check-unimported`
Run status	`Passed #4604`
Run duration	`05m 55s`
Commit	`8724131343: Add lint checks to scan for un-imported files and unused packages`
Committer	`Rithvik Nishad`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`10`
View all changes introduced in this branch ↗︎

github-actions · 2025-02-04T13:55:40Z

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

rithviknishad added 2 commits February 4, 2025 18:45

Update lint checks to scan for unimported files

0e4ff8a

run on pre-commit

57a7049

rithviknishad requested a review from a team as a code owner February 4, 2025 13:21

rithviknishad requested a review from sainak February 4, 2025 13:22

updated unimported config

b73766d

update config

8724131

rithviknishad requested a review from Jacobjeevan February 4, 2025 13:32

Jacobjeevan approved these changes Feb 4, 2025

View reviewed changes

amjithtitus09 approved these changes Feb 4, 2025

View reviewed changes

rithviknishad merged commit 879c583 into develop Feb 4, 2025
22 checks passed

rithviknishad deleted the rithviknishad/chore/lint-check-unimported branch February 4, 2025 13:55

coderabbitai bot mentioned this pull request Feb 11, 2025

skip unimported check in pre-commit #10557

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add lint checks to scan for un-imported files and unused packages #10390

Add lint checks to scan for un-imported files and unused packages #10390

rithviknishad commented Feb 4, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 4, 2025 •

edited

Loading

Rate limit exceeded

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Feb 4, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 4, 2025 •

edited

Loading

cypress bot commented Feb 4, 2025 •

edited

Loading

github-actions bot commented Feb 4, 2025

Add lint checks to scan for un-imported files and unused packages #10390

Add lint checks to scan for un-imported files and unused packages #10390

Conversation

rithviknishad commented Feb 4, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Feb 4, 2025 • edited Loading

Rate limit exceeded

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Feb 4, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

cloudflare-workers-and-pages bot commented Feb 4, 2025 • edited Loading

Deploying care-fe with Cloudflare Pages

cypress bot commented Feb 4, 2025 • edited Loading

CARE Run #4604

github-actions bot commented Feb 4, 2025

rithviknishad commented Feb 4, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 4, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 4, 2025 •

edited

Loading

cypress bot commented Feb 4, 2025 •

edited

Loading