Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Remove unnecessary GitHub workflows #10342

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jan 31, 2025

Summary by CodeRabbit

  • Workflow Removals
    • Deleted multiple GitHub Actions workflows related to issue and pull request management
    • Removed automated labeling and commenting workflows
    • Updated linter workflow to use Node.js 22 and trigger only on develop branch

@rithviknishad rithviknishad requested a review from a team as a code owner January 31, 2025 16:46
Copy link
Contributor

coderabbitai bot commented Jan 31, 2025

Walkthrough

This pull request involves the removal and modification of several GitHub Actions workflow files in the .github/workflows/ directory. Multiple workflows related to issue and pull request management, such as auto-labeling, commenting, and deployment tracking, have been deleted. The linter.yml workflow was slightly modified to update the Node.js version and restrict the trigger branches. These changes appear to be a cleanup and simplification of the repository's CI/CD and automation processes.

Changes

File Change Summary
.github/workflows/auto-testing-label.yml Deleted workflow for automatically adding "needs testing" label
.github/workflows/combine.yml Deleted workflow for combining dependencies
.github/workflows/comment-p1-issues.yml Deleted workflow for commenting on P1 issues
.github/workflows/label-deploy-failed.yml Deleted workflow for labeling failed preview deployments
.github/workflows/label-wip.yml Deleted workflow for auto-labeling work-in-progress issues
.github/workflows/label-merge-conflict.yml Updated conflict comment message
.github/workflows/linter.yml Updated Node.js version to 22 and restricted trigger branches

Possibly related PRs

Suggested labels

needs review

Suggested reviewers

  • shivankacker

Poem

🐰 Workflows dancing, some take flight,
Automation's rhythm, now streamlined and light
Deleted scripts, a digital clean sweep
Linter's version bumped, improvements to keep
CI/CD magic, simplified with care! 🤖


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4d9e7d0 and 1469f19.

📒 Files selected for processing (7)
  • .github/workflows/auto-testing-label.yml (0 hunks)
  • .github/workflows/combine.yml (0 hunks)
  • .github/workflows/comment-p1-issues.yml (0 hunks)
  • .github/workflows/label-deploy-failed.yml (0 hunks)
  • .github/workflows/label-merge-conflict.yml (1 hunks)
  • .github/workflows/label-wip.yml (0 hunks)
  • .github/workflows/linter.yml (1 hunks)
💤 Files with no reviewable changes (5)
  • .github/workflows/label-deploy-failed.yml
  • .github/workflows/combine.yml
  • .github/workflows/comment-p1-issues.yml
  • .github/workflows/label-wip.yml
  • .github/workflows/auto-testing-label.yml
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: cypress-run (1)
  • GitHub Check: OSSAR-Scan
🔇 Additional comments (2)
.github/workflows/linter.yml (1)

24-24: Consider using Node.js 20 LTS instead of Node.js 22.

Node.js 22 is currently in beta and not recommended for production use. Consider using Node.js 20 which is the current LTS (Long Term Support) version.

Run the following script to check the Node.js release schedule:

✅ Verification successful

Node.js 22 is not production-ready, switch to Node.js 20 LTS

The verification confirms that Node.js 20 is the current LTS release (codename "Iron") while Node.js 22 is not marked as LTS, making it unsuitable for production use. Using Node.js 20 LTS will ensure better stability and long-term support.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check Node.js release schedule and LTS status.
curl -s https://raw.githubusercontent.com/nodejs/Release/main/schedule.json | jq '.[] | select(.version == "v22" or .version == "v20") | {version: .version, start: .start, lts: .lts, maintenance: .maintenance, end: .end}'

Length of output: 223


Script:

#!/bin/bash
# Try multiple sources to verify Node.js version information
echo "=== Checking nodejs.org ==="
curl -s https://nodejs.org/dist/index.json | jq '[.[] | select(.version | startswith("v20.") or startswith("v22.")) | {version: .version, lts: .lts}] | sort_by(.version) | reverse | .[0:3]'

echo -e "\n=== Checking npm registry ==="
curl -s https://registry.npmjs.org/node/latest | jq '{latest: .version, lts: ."dist-tags".lts}'

Length of output: 628


Script:

#!/bin/bash
# Check specifically for Node.js 20.x versions
echo "=== Checking Node.js 20.x versions ==="
curl -s https://nodejs.org/dist/index.json | jq '[.[] | select(.version | startswith("v20.")) | {version: .version, lts: .lts}] | sort_by(.version) | reverse | .[0:3]'

Length of output: 416

.github/workflows/label-merge-conflict.yml (1)

28-29: Verify the accessibility of the documentation link.

Please ensure that the documentation link is accessible to external contributors who might not have access to the internal domain.

Run the following script to verify the documentation link:

✅ Verification successful

Documentation link is accessible

The documentation link is properly configured and publicly accessible through Netlify, making it suitable for external contributors.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if the documentation link is accessible.
curl -I https://docs.ohc.network/docs/contributing

Length of output: 786


Script:

#!/bin/bash
# Follow redirects and show final status
curl -IL https://docs.ohc.network/docs/contributing/

Length of output: 757


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 1469f19
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/679cfe60471a9d0008442190
😎 Deploy Preview https://deploy-preview-10342--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad rithviknishad requested a review from bodhish January 31, 2025 16:46
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never seen this working most of the time

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renovate took over the job

Copy link

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1469f19
Status: ✅  Deploy successful!
Preview URL: https://4a2ba2f5.care-fe.pages.dev
Branch Preview URL: https://rithviknishad-maintenance-re.care-fe.pages.dev

View logs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove of label doesn't work automatically. the CI actions ticks is sufficient.

Copy link
Member Author

@rithviknishad rithviknishad Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linked PRs icon and/or project sprint board is sufficient

Copy link

cypress bot commented Jan 31, 2025

CARE    Run #4559

Run Properties:  status check passed Passed #4559  •  git commit 1469f194af: Cleanup: Remove unnecessary GitHub workflows
Project CARE
Branch Review rithviknishad/maintenance/remove-useless-workflows
Run status status check passed Passed #4559
Run duration 05m 56s
Commit git commit 1469f194af: Cleanup: Remove unnecessary GitHub workflows
Committer Rithvik Nishad
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 10
View all changes introduced in this branch ↗︎

Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bodhish bodhish merged commit 6f77a69 into develop Jan 31, 2025
26 checks passed
@bodhish bodhish deleted the rithviknishad/maintenance/remove-useless-workflows branch January 31, 2025 17:16
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants