Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebel airstrike fixes #3473

Conversation

Tiny-DM
Copy link

@Tiny-DM Tiny-DM commented Dec 29, 2024

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Information:
addBombRun actually checks the vehicle type now
NATObomb will now properly clean up vehicles, a sleep for an unknown variable caused stuff to be instantly deleted
Hopefully the entire natoBomb function can be reworked with the GUI update

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:
addBombRun: attempt to sell a helicopter or plane from the enemy factions for airstrikes, it returns the proper amount
NATObomb: call an airstrike, shoot down the plane on approach. it crashes and despawns an hour later.

@Tiny-DM Tiny-DM added Priority Should be fixed first Bug Something isn't working labels Dec 29, 2024
@Tiny-DM Tiny-DM added this to the 3.8.0 milestone Dec 29, 2024
@Tiny-DM Tiny-DM requested a review from ante185 December 29, 2024 03:16
Copy link
Collaborator

@jaj22 jaj22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go in 3.8.0.

@Bob-Murphy Bob-Murphy merged commit c34c602 into official-antistasi-community:unstable Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Priority Should be fixed first Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants