Repository navigation
docs: add theme-aware dashboard screenshots to the live dashboard guide - #232
Merged
Merged
Conversation
Adds real dark/light screenshots of the /__svelte-vitals/ dashboard to the guide (en + ja), swapped via CSS keyed off Starlight's data-theme attribute so the screenshot follows the docs site's own theme toggle. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013wEzbEuUrQT5ARaqpdrkxL
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe documentation adds dark- and light-theme dashboard screenshots to the English and Japanese guides. Astro loads a stylesheet that displays the screenshot matching the active Starlight theme. ChangesTheme-aware documentation images
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/__svelte-vitals/live dashboard to the Live dashboard guide, in both English and Japanese.data-themeattribute on<html>(docs/src/styles/theme-image.css, registered ascustomCss) — no client JS of our own.Test plan
astro buildcompletes (125 pages)pnpm exec prettier --checkon changed filesastro dev: toggling the site's theme selector (Auto/Dark/Light) swaps the screenshot on both/guides/dev-dashboard/and/ja/guides/dev-dashboard/🤖 Generated with Claude Code
https://claude.ai/code/session_013wEzbEuUrQT5ARaqpdrkxL
Summary by CodeRabbit