-
Notifications
You must be signed in to change notification settings - Fork 71
Session & debounce #6162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Session & debounce #6162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `session.move` do nothing if `session.join` is not called beforehand. But as it turns out, we do actually call `session.move` before `session.join`. It just always work in practice, because `session.move` is debounced. With this commit, we store the client position in `session.move`, and send it to the server when `session.join` is called. Task: 4737879
We had a `index.ts` file for some registries. The file was a bit of a
problem because:
- It mixes apples and oranges: some registries are purely UI, some not,
so importing everything at once don't really make sense.
- It is an easy source of circular dependencies. For example, we had
to split `side_panel_registry` in two files to avoid circular dependencies
This commit removes the `index.ts` file and imports the registries
individually where needed.
Task: 4737879
Collaborator
89b8deb to
52ebce2
Compare
14 tasks
Collaborator
|
@robodoo rebase-ff |
Collaborator
|
Merge method set to rebase and fast-forward. |
When creating a model, we trigger a `session.move` that is debounced, and that trigger a render when the debounce is over. This can lead to indeterministic tests, with random renders happening in the middle of a test. This commit removes the debounce of `session.move` for all the tests. Task: 4737879
52ebce2 to
4254065
Compare
LucasLefevre
approved these changes
Apr 30, 2025
Collaborator
LucasLefevre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
robodoo r+
robodoo
pushed a commit
that referenced
this pull request
Apr 30, 2025
Currently, `session.move` do nothing if `session.join` is not called beforehand. But as it turns out, we do actually call `session.move` before `session.join`. It just always work in practice, because `session.move` is debounced. With this commit, we store the client position in `session.move`, and send it to the server when `session.join` is called. Task: 4737879 Part-of: #6162 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Apr 30, 2025
We had a `index.ts` file for some registries. The file was a bit of a
problem because:
- It mixes apples and oranges: some registries are purely UI, some not,
so importing everything at once don't really make sense.
- It is an easy source of circular dependencies. For example, we had
to split `side_panel_registry` in two files to avoid circular dependencies
This commit removes the `index.ts` file and imports the registries
individually where needed.
Task: 4737879
Part-of: #6162
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Apr 30, 2025
When creating a model, we trigger a `session.move` that is debounced, and that trigger a render when the debounce is over. This can lead to indeterministic tests, with random renders happening in the middle of a test. This commit removes the debounce of `session.move` for all the tests. closes #6162 Task: 4737879 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description:
[FIX] tests: indeterministic tests with
debounceWhen creating a model, we trigger a
session.movethat is debounced,and that trigger a render when the debounce is over. This can lead to
indeterministic tests, with random renders happening in the middle of
a test.
This commit removes the debounce of
session.movefor all the tests.[IMP] registries: remove registries index
We had a
index.tsfile for some registries. The file was a bit of aproblem because:
so importing everything at once don't really make sense.
to split
side_panel_registryin two files to avoid circular dependenciesThis commit removes the
index.tsfile and imports the registriesindividually where needed.
[IMP] session: better handling of
session.moveCurrently,
session.movedo nothing ifsession.joinis not calledbeforehand. But as it turns out, we do actually call
session.movebefore
session.join. It just always work in practice, becausesession.moveis debounced.With this commit, we store the client position in
session.move, andsend it to the server when
session.joinis called.Task: 4737879
review checklist