[FIX] spreadsheet: parasitic render at every click #6145
Conversation
|
|
| jest.useFakeTimers(); | ||
| model = new Model(data, { external: { geoJsonService: mockGeoJsonService } }); | ||
| jest.advanceTimersByTime(DEBOUNCE_TIME + 10); // wait for the debounce of session.move | ||
| jest.useRealTimers(); |
There was a problem hiding this comment.
I don't understand how this is not more of a problem. Inside every single test there is parasitic renders happening in the middle of the test because of debounced session.move. Idk how we don't have more indeterministic tests ...
There was a problem hiding this comment.
Actually scratch that, this is a problem. I'm 80% sure that's why the composer component tests keep randomly failing on my machine ....
There was a problem hiding this comment.
I don't recall if we found a idea to solve this? I only recall the ideas:
- skipping the first debounce
- having an overall mock of the session in the tests but it lead to the import nightmare...
There was a problem hiding this comment.
Fixed in another PR :) (In master, because it needed some tweaks in the file structure)
hokolomopo
force-pushed
the
master-onclick-parasitic-render-adrm
branch
from
5f8092d to
c5ffee5
Compare
rrahir
left a comment
rrahir
left a comment
There was a problem hiding this comment.
🚚 50/50 (I hope) on the comments relevance
| jest.useFakeTimers(); | ||
| model = new Model(data, { external: { geoJsonService: mockGeoJsonService } }); | ||
| jest.advanceTimersByTime(DEBOUNCE_TIME + 10); // wait for the debounce of session.move | ||
| jest.useRealTimers(); |
There was a problem hiding this comment.
I don't recall if we found a idea to solve this? I only recall the ideas:
- skipping the first debounce
- having an overall mock of the session in the tests but it lead to the import nightmare...
Since the topbar refactor, a new render is triggered at every single click event, no matter where we click. This breaks every input with `t-att-value`, their content is reset at each click. Task: 4737827
hokolomopo
force-pushed
the
master-onclick-parasitic-render-adrm
branch
from
c5ffee5 to
cbf59c1
Compare
|
@robodoo r+ |
Since the topbar refactor, a new render is triggered at every single click event, no matter where we click. This breaks every input with `t-att-value`, their content is reset at each click. closes #6145 Task: 4737827 Signed-off-by: Rémi Rahir (rar) <[email protected]>
3 participants
Description
Since the topbar refactor, a new render is triggered at every single click event, no matter where we click. This breaks every input with
t-att-value, their content is reset at each click.Task: 4737827
review checklist