chore(odiglet): remove unused rbac permission in replicasets (#2178)

It was used in old runtime detection. Now that this is removed, we no longer need replicasets permissions for odiglets and can clean this up
odigos-io · Jan 10, 2025 · 7e8571a · 7e8571a
1 parent 5b5a12b
commit 7e8571a
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 13 deletions.
diff --git a/cli/cmd/resources/README.md b/cli/cmd/resources/README.md
@@ -11,7 +11,6 @@ In this doc, we'll keep track of the permissions requested across different reso
 | Odiglet      | ""                | nodes                                                      | get, list, watch                                | Needed for virtual device registration.                                                                                   |
 | Odiglet      | apps              | deployments, daemonsets, statefulsets                      | get, list, watch                                | Needed for language detection (temporary until new detection logic is ready).                                             |
 | Odiglet      | apps              | deployments/status, daemonsets/status, statefulsets/status | get                                             | Needed for language detection (temporary until new detection logic is ready).                                             |
-| Odiglet      | apps              | replicasets                                                | get                                             | Needed for language detection (temporary until new detection logic is ready).                                             |                                                                          |
 | Odiglet      | odigos.io         | instrumentationinstances                                   | create, get, list, patch, update, watch, delete | Manages instrumentation instances for process state storage.                                                              |
 | Odiglet      | odigos.io         | instrumentationinstances/status                            | get, patch, update                              | Updates status of instrumentation instances.                                                                              |
 | Odiglet      | odigos.io         | instrumentationconfigs                                     | get, list, watch, patch, update                 | Manages instrumentation configurations (future update for runtime details storage).                                       |

diff --git a/cli/cmd/resources/odiglet.go b/cli/cmd/resources/odiglet.go
@@ -135,12 +135,6 @@ func NewOdigletClusterRole(psp bool) *rbacv1.ClusterRole {
 				Resources: []string{"deployments/status", "daemonsets/status", "statefulsets/status"},
 				Verbs:     []string{"get"},
 			},
-			{ // Needed for language detection
-				// TODO: remove this once Tamir/PR is read for new language detection
-				APIGroups: []string{"apps"},
-				Resources: []string{"replicasets"},
-				Verbs:     []string{"get"},
-			},
 			{ // Needed for virtual device registration
 				APIGroups: []string{""},
 				Resources: []string{"nodes"},

diff --git a/helm/odigos/templates/odiglet/clusterrole.yaml b/helm/odigos/templates/odiglet/clusterrole.yaml
@@ -35,12 +35,6 @@ rules:
       - statefulsets/status
     verbs:
       - get
-  - apiGroups:
-      - apps
-    resources:
-      - replicasets
-    verbs:
-      - get
   - apiGroups:
       - ''
     resources: