Skip to content

Commit

Permalink
chore: remove unused odigos config controller (#2177)
Browse files Browse the repository at this point in the history
The controller for the instrumentation config was needed for old
language detection which was triggered from instrumentor.

New language detection will be triggered once when the instrumentation
config is first created, and use whatever values are in the config at
this time.

Hence this controller can be removed
  • Loading branch information
blumamir authored Jan 10, 2025
1 parent 899906b commit 5b5a12b
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 156 deletions.
15 changes: 0 additions & 15 deletions instrumentor/controllers/startlangdetection/manager.go
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
package startlangdetection

import (
odigospredicate "github.com/odigos-io/odigos/k8sutils/pkg/predicate"
appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/builder"
"sigs.k8s.io/controller-runtime/pkg/predicate"
)

func SetupWithManager(mgr ctrl.Manager) error {
Expand Down Expand Up @@ -61,18 +59,5 @@ func SetupWithManager(mgr ctrl.Manager) error {
return err
}

err = builder.
ControllerManagedBy(mgr).
Named("startlangdetection-configmaps").
For(&corev1.ConfigMap{}).
WithEventFilter(predicate.And(odigospredicate.OdigosEffectiveConfigMapPredicate, odigospredicate.ConfigMapDataChangedPredicate{})).
Complete(&OdigosConfigReconciler{
Client: mgr.GetClient(),
Scheme: mgr.GetScheme(),
})
if err != nil {
return err
}

return nil
}

This file was deleted.

45 changes: 0 additions & 45 deletions k8sutils/pkg/predicate/cm_changed.go

This file was deleted.

0 comments on commit 5b5a12b

Please sign in to comment.