Adapt Windows opam-repository to new git safe.directory setting #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterDA
commented
Sep 1, 2022
src-opam/dockerfile_windows.ml
Outdated
| run "git config --global user.email %S && git config --global user.name %S && git config --system core.longpaths true" email name | ||
| run "git config --global user.email %S && \ | ||
| git config --global user.name %S && \ | ||
| git config --global core.longpaths true && \ |
Contributor
Author
There was a problem hiding this comment.
Note that the user doesn't have the permissions to set directives system-wide, so I also fixed core.longpaths to --global. By default, cygwin's git is used.
Collaborator
There was a problem hiding this comment.
Is it possible to do this earlier in a step as ContainerAdministrator?
Contributor
Author
There was a problem hiding this comment.
I re-tested and must have misread, the --system switch for core.longpaths worked as expected, both for Cygwin's git and Git for Windows. Reverting that change.
As a side note, the user is always Container Administrator. I haven't created another user.
Mitigations added for CVE-2022-24765 cause error messages as the owner of the git checkout won't be correct. It simply doesn't matter on a CI system, so just add the directory to safe.directory to ignore it.
MisterDA
force-pushed
the
fix-git-windows
branch
from
0fde203 to
cbcd828
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigations added for CVE-2022-24765 cause error messages as the owner
of the git checkout won't be correct. It simply doesn't matter on a CI
system, so just add the directory to safe.directory to ignore it.
cc @dra27