Some misc. chores #106
Merged
Some misc. chores #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterDA
force-pushed
the
misc
branch
2 times, most recently
from
f1d249f to
9aa9c24
Compare
tmcgilchrist
reviewed
Sep 8, 2022
tmcgilchrist
reviewed
Sep 8, 2022
tmcgilchrist
approved these changes
Sep 8, 2022
.ocamlformat
Outdated
| @@ -0,0 +1,3 @@ | |||
| profile = conventional | |||
| version = 0.24.1 | |||
| ocaml-version = 4.11 | |||
Member
There was a problem hiding this comment.
Is there a strong reason to move the OCaml version this far forward?
https://ocaml.org/p/dockerfile/8.0.0 supports back to 4.02.3
Contributor
Author
There was a problem hiding this comment.
We can remove the dependency on rresult, use new functions from the standard library. I think there's a case for moving slowly to new versions. An informal rule is to support the last three OCaml versions. I can go back to 4.10 for now.
Contributor
Author
There was a problem hiding this comment.
the CI doesn't currently test before 4.07.
MisterDA
force-pushed
the
misc
branch
2 times, most recently
from
6690f40 to
028b6be
Compare
Contributor
Author
|
I've also added code to refactor the Git setup, as a follow-up of #108. |
- `Dockerfile_gen` from the `dockerfile-cmd` package becomes `Dockerfile_cmd.Gen`; - `Dockerfile_distro`, `Dockerfile_linux`, `Dockerfile_windows` from the `dockerfile_opam` package respectively become `Dockerfile_opam.Distro`, `Dockerfile_opam.Linux`, `Dockerfile_opam.Windows`.
Contributor
Author
|
Changed to use Dune 3.0 and OCaml 4.08. |
tmcgilchrist
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.