Skip to content

btrfs: Check that the current kernel version will not have issues down the line #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
talex5 merged 5 commits into from
Apr 23, 2021
Merged

btrfs: Check that the current kernel version will not have issues down the line #68

talex5 merged 5 commits into from
Apr 23, 2021

Conversation

@kit-ty-kate
Copy link
Contributor

@kit-ty-kate kit-ty-kate commented Apr 16, 2021

Fixes #47

@kit-ty-kate
Copy link
Contributor Author

kit-ty-kate commented Apr 19, 2021

This check also seems to "fix" (or at least make less common) the issue opam-repo-ci was experiencing, described in ocurrent/ocurrent#261 (comment)

talex5
talex5 reviewed Apr 20, 2021
View reviewed changes
Copy link
Contributor

@talex5 talex5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Btrfs only works on Linux, so this should be fine for now.

@kit-ty-kate
Copy link
Contributor Author

kit-ty-kate commented Apr 22, 2021

I've added a commit that reverts #43 because I believe this should not be required anymore and might help some high-core-count workers experiencing slowdowns (e.g. pima)

@talex5
Copy link
Contributor

talex5 commented Apr 22, 2021

Looks good - the Travis tests need updating to test on a newer Ubuntu, though!

@kit-ty-kate
Copy link
Contributor Author

kit-ty-kate commented Apr 22, 2021 •
edited
Loading

Sadly Travis-CI doesn't seem to have support for non-LTS version of Ubuntu. Github Actions doesn't seem to support that either. What should we do?

@talex5
Copy link
Contributor

talex5 commented Apr 22, 2021

Oh. Maybe add a fake uname script to $PATH during the tests?

@kit-ty-kate
Copy link
Contributor Author

kit-ty-kate commented Apr 23, 2021

Oh. Maybe add a fake uname script to $PATH during the tests?

Thanks for the idea! This is done and CI now passes.

@talex5 talex5 merged commit ee67a5c into ocurrent:master Apr 23, 2021
@talex5
Copy link
Contributor

talex5 commented Apr 23, 2021

Thanks!

@kit-ty-kate kit-ty-kate deleted the fix-btrfs-failures branch April 28, 2021 11:45
tmcgilchrist added a commit to tmcgilchrist/opam-repository that referenced this pull request Jun 17, 2022
@tmcgilchrist
[new release] obuilder and obuilder-spec (0.4)
7fe2685 
CHANGES:

- Use GNU tar format instead of UStar for `copy` operations (@TheLortex ocurrent/obuilder#82, reviewed @dra27).
  This enables copying from sources containing long file names (>100 characters).

- Add support for secrets (@TheLortex ocurrent/obuilder#63, reviewed by @talex5).
  The obuilder spec's `run` command supports a new `secrets` fields, which allows to temporarily
  mount secret files in an user-specified location. The sandbox build context has an additional
  `secrets` parameter to provide values for the requested keys.

- Limit permissions on temporary directories (@talex5 ocurrent/obuilder#67)

- Check Linux kernel version support for btrfs (@kit-ty-kate ocurrent/obuilder#68)

- Generalise obuilder sandbox, removing runc/linux specifc pieces and
  making the S.SANDBOX interface more general
  (@patricoferris ocurrent/obuilder#58, reviewed by @talex5, @avsm, @MisterDA)

- Convert --fast-sync back to a flag (@talex5 ocurrent/obuilder#72)

- Support Fmt.cli and Logs.cli flags. (@MisterDA ocurrent/obuilder#74, reviewed by @talex5)
  For Fmt the new options are --color=always|never|auto
  For Log the new options are:
    -v, --verbose Increase verbosity
    --verbosity=LEVEL (absent=warning)
        Be more or less verbose. LEVEL must be one of quiet, error,
        warning, info or debug. Takes over -v.

- Minor cleanup changes (@talex5 ocurrent/obuilder#76)

- Fix deprecations in Fmt 0.8.10 (@tmcgilchrist ocurrent/obuilder#80)

- Remove travis-ci and replace with Github Actions (@MisterDA ocurrent/obuilder#84)

- Add RSync store backend for obuilder to support macOS builders (@patricoferris ocurrent/obuilder#88, reviewed @talex5)

- Fixes for ZFS tests in CI (@patricoferris ocurrent/obuilder#91)
@tmcgilchrist tmcgilchrist mentioned this pull request Jun 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@talex5 talex5 talex5 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Btrfs bug tracking

2 participants

@kit-ty-kate @talex5