Skip to content

Conversation

@patricoferris
Copy link
Contributor

This PR fixes #89 for CI.

@talex5 wasn't quite sure what you wanted when you said

And maybe link to the issue from the error message?

@talex5 talex5 merged commit 7ca020a into ocurrent:master Nov 29, 2021
@talex5
Copy link
Contributor

talex5 commented Nov 29, 2021

Thanks!

I only meant that instead of just printing "ZFS cannot promote: not a cloned filesystem" on error, we could also give the user a hint about what the problem was. But maybe it's difficult to detect this case, and searching will probably turn up the issue easily enough.

@patricoferris patricoferris mentioned this pull request Dec 2, 2021
6 tasks
tmcgilchrist added a commit to tmcgilchrist/opam-repository that referenced this pull request Jun 17, 2022
CHANGES:

- Use GNU tar format instead of UStar for `copy` operations (@TheLortex ocurrent/obuilder#82, reviewed @dra27).
  This enables copying from sources containing long file names (>100 characters).

- Add support for secrets (@TheLortex ocurrent/obuilder#63, reviewed by @talex5).
  The obuilder spec's `run` command supports a new `secrets` fields, which allows to temporarily
  mount secret files in an user-specified location. The sandbox build context has an additional
  `secrets` parameter to provide values for the requested keys.

- Limit permissions on temporary directories (@talex5 ocurrent/obuilder#67)

- Check Linux kernel version support for btrfs (@kit-ty-kate ocurrent/obuilder#68)

- Generalise obuilder sandbox, removing runc/linux specifc pieces and
  making the S.SANDBOX interface more general
  (@patricoferris ocurrent/obuilder#58, reviewed by @talex5, @avsm, @MisterDA)

- Convert --fast-sync back to a flag (@talex5 ocurrent/obuilder#72)

- Support Fmt.cli and Logs.cli flags. (@MisterDA ocurrent/obuilder#74, reviewed by @talex5)
  For Fmt the new options are --color=always|never|auto
  For Log the new options are:
    -v, --verbose Increase verbosity
    --verbosity=LEVEL (absent=warning)
        Be more or less verbose. LEVEL must be one of quiet, error,
        warning, info or debug. Takes over -v.

- Minor cleanup changes (@talex5 ocurrent/obuilder#76)

- Fix deprecations in Fmt 0.8.10 (@tmcgilchrist ocurrent/obuilder#80)

- Remove travis-ci and replace with Github Actions (@MisterDA ocurrent/obuilder#84)

- Add RSync store backend for obuilder to support macOS builders (@patricoferris ocurrent/obuilder#88, reviewed @talex5)

- Fixes for ZFS tests in CI (@patricoferris ocurrent/obuilder#91)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ZFS cannot promote: not a cloned filesystem

2 participants