Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generators project for source generation #2537

Merged
merged 9 commits into from
Aug 11, 2022
Merged

Conversation

nickfloyd
Copy link
Contributor

@nickfloyd nickfloyd commented Aug 10, 2022

Fixes: #2534

This PR intends to add an iteration 0 for code generation. The initial generator was sourced from the work @Saalvage did when adding the AsyncPaginationExtensions.

This PR:

  • Adds the generator project
  • Adds the first generator - AsyncPaginationExtensions (initial approach - future iterations will dive into using things such as Rosyln and source templates
  • Adds a readme explaining how to use this project and why we are doing it
  • Regenerates the extensions - there are deltas due to white space, some template modification, and ordinality of the generated implementations

Note: The existing test coverage for the extensions is still intact, and I intentionally left testing off of the generations project because:

  1. It was redundant to test the generated extensions
  2. This project is effectively a prototype for code generation and is proven through compiling the source it has generated

@nickfloyd nickfloyd requested a review from timrogers August 10, 2022 02:34
@nickfloyd nickfloyd marked this pull request as ready for review August 10, 2022 02:50
@nickfloyd nickfloyd requested a review from JonruAlveus August 10, 2022 13:14
Octokit.Generators/README.md Outdated Show resolved Hide resolved
Octokit.Generators/Octokit.Generators.csproj Outdated Show resolved Hide resolved
Octokit.Generators/Octokit.Generators.csproj Outdated Show resolved Hide resolved
Octokit.Generators/Octokit.Generators.csproj Show resolved Hide resolved
Octokit.Generators/Generator.cs Show resolved Hide resolved
@nickfloyd nickfloyd requested a review from JonruAlveus August 10, 2022 21:56
@nickfloyd nickfloyd merged commit 1e3fa1d into main Aug 11, 2022
@nickfloyd nickfloyd deleted the add-generators-project branch August 11, 2022 06:34
@nickfloyd
Copy link
Contributor Author

release_notes: Adds generators project and AsyncPaginationExtension generator

@nickfloyd nickfloyd added Type: Documentation Improvements or additions to documentation Type: Feature New feature or request and removed category: docs-and-samples labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Improvements or additions to documentation Type: Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add generators project for current and future generative features
2 participants