Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generators project for current and future generative features #2534

Closed
nickfloyd opened this issue Aug 8, 2022 · 0 comments · Fixed by #2537
Closed

Add generators project for current and future generative features #2534

nickfloyd opened this issue Aug 8, 2022 · 0 comments · Fixed by #2537
Assignees
Labels
Type: Feature New feature or request

Comments

@nickfloyd
Copy link
Contributor

related: #2516

From the reference PR

Given that we are headed down to a more generative SDK (see the discussions #2499 and #2495 and #2517 for more info on that)

IMO the preferred approach would be to have a generators project with namespaced scrips i.e.
Octokit.Generators and the generator above would be something like Octokit.Generators.AsyncPaginationExtension (as an example).

This way, we're establishing the future location for all generators to remove this question later. Also, this will allow us to use CI to build the generators, generate the code, and commit it before the other aspects of the SDK are built.

As a side note, in my perfect world brain, all models and related libs would be hoisted out of this SDK and referenced in as a package so that we could better support versioning and be able to ship SDK core changes separate from SDK model changes.

Let's create a generators project, add the script detailed in the PR, then document how to run and what to expect - we can do a follow-up for CI to implement this more automatedly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant