Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Added support for Repository Topics, unit tests to be added #1721

Closed
wants to merge 3 commits into from

Conversation

MuazOthman
Copy link

This pull request is addressing #1707

  • Add Topics field to Repository response class
  • Specify new preview header on all calls that return Repository responses
  • Update unit tests to pass after adding preview header
  • New API: List all Topics
  • Write unit tests for List all Topics (done partially)
  • New API: Replace all Topics
  • Write unit tests for Replace all Topics
  • Add string Topic field to SearchRepositoriesRequest and format search parameters accordingly
  • Add Range Topics field to SearchRepositoriesRequest and format search parameters accordingly

@ryangribble
Copy link
Contributor

Hi @MuazOthman just wondering if you still want this PR kept open?

@MuazOthman
Copy link
Author

@ryangribble sorry for the late response, it's crunch time at work these days! Please keep this open if possible, I'll try to get back to it as soon as I get the chance.

@jonnii
Copy link

jonnii commented May 30, 2018

What's left to get this over the line? Anything I can do to help?

@MuazOthman
Copy link
Author

That would be great! The checklist above can provide guidance to what's still to do.
I can add you to my repo if you want and you're welcome to pick it up there.

@jonnii
Copy link

jonnii commented May 31, 2018

@MuazOthman if you add me I'll see what I can do.

@MuazOthman
Copy link
Author

@jonnii I just invited you, thanks for offering to help

@jozefizso
Copy link
Contributor

Is this being working on? Do you need help with getting this implementation done?

@ryangribble
Copy link
Contributor

Hi @jozefizso it would be awesome if you wanted to pick this one up!

@jozefizso
Copy link
Contributor

sure

# Conflicts:
#	Octokit.Tests/Clients/RepositoriesClientTests.cs
#	Octokit.Tests/Reactive/ObservableRepositoriesClientTests.cs
#	Octokit/Clients/RepositoriesClient.cs
#	Octokit/Helpers/AcceptHeaders.cs
#	Octokit/Models/Response/Repository.cs
@exavian
Copy link

exavian commented Jul 3, 2019

@MuazOthman Are you still keeping an eye on this? I grabbed the changes from this PR and have put in some work.

@KeesCBakker
Copy link

Any progress on this topic?

Merged master changes to topics feature branch.
@shiftkey shiftkey changed the base branch from master to main June 9, 2020 21:31
@SeanKilleen SeanKilleen mentioned this pull request Sep 8, 2020
20 tasks
SeanKilleen added a commit to SeanKilleen/octokit.net that referenced this pull request Sep 9, 2020
@SeanKilleen
Copy link
Contributor

Hey all,

FYI, I have a PR (#2246) that supersedes this to tackle #1707.

If you worked on this pull request, I'd welcome your input/review over at #2246.

@shiftkey
Copy link
Member

Closing this out in favour of #2246, which should be out in the next release

@shiftkey shiftkey closed this Feb 21, 2021
@nickfloyd nickfloyd added Type: Feature New feature or request and removed category: feature labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants