Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Repository Topics #1707

Closed
ryangribble opened this issue Nov 5, 2017 · 9 comments · Fixed by #2246
Closed

Add support for Repository Topics #1707

ryangribble opened this issue Nov 5, 2017 · 9 comments · Fixed by #2246
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request

Comments

@ryangribble
Copy link
Contributor

ryangribble commented Nov 5, 2017

https://github.com/blog/2309-introducing-topics
https://help.github.com/articles/about-topics/

Response Class Support

  • Add Topics field to Repository response class
  • Specify new preview header on all calls that return Repository responses

New API Calls

Support Search Repositories by Topic
https://help.github.com/articles/searching-repositories/#search-by-repository-topic

  • Add string Topic field to SearchRepositoriesRequest and format search parameters accordingly
  • Add Range Topics field to SearchRepositoriesRequest and format search parameters accordingly

See #1704

@MikhailTymchukDX
Copy link
Contributor

MikhailTymchukDX commented Jul 4, 2018

Not implemented yet?
What are options to search by topics?

@ryangribble
Copy link
Contributor Author

There is a work on progress PR #1721 but the contributors dropped off. I'm currently focusing on the checks API stuff so it would be wonderful if you could help on that PR if you've got a use case for the topics support @MikhailTymchukDX?

@BarbourSmith
Copy link

BarbourSmith commented Mar 10, 2019

What is the status of this? The documentation implies that it is working, but it says "For example: " but the example has not been written yet

Edit: It seems like the octokit documentation may be pulling directly from the GitHub api documentation which would explain the discrepancy

@ryangribble
Copy link
Contributor Author

Hi @BarbourSmith , the documentation you are referring to is for octokit.js the javascript API client, whilst this is the c# client. It looks like we still haven't had any traction on finishing that old PR #1721 off, so as of now Repository Topics are still not supported in the c# client unfortauntely 😞

@BarbourSmith
Copy link

Sorry guys, I didn't realize I was in the c# client... 😬

@SeanKilleen
Copy link
Contributor

Hey! I'd love this functionality in an app I'm building so I'm going to jump in and try to knock it out.

I will use #1721 as a reference.

@JustinGol
Copy link

@SeanKilleen, not sure Im missing something but I cant find the new method GetAllTopics on the RepositoryClient. Im using v0.50, double checked and decomplied. I saw in the release the commit for this is included. I can see it in the integration tests too so not sure whats happening. TIA

image
image

@SeanKilleen
Copy link
Contributor

@JustinGol please file a new issue, tag me, and include an example of how you're attempting to use it. I'll do what I can to help. Thanks!

@JustinGol
Copy link

JustinGol commented May 24, 2021

@JustinGol please file a new issue, tag me, and include an example of how you're attempting to use it. I'll do what I can to help. Thanks!

Thanks @SeanKilleen, its here: #2328. Appreciate your help on this.

@nickfloyd nickfloyd added Type: Feature New feature or request Status: Up for grabs Issues that are ready to be worked on by anyone and removed category: feature labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants