Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): installation authentication type #283

Merged
merged 9 commits into from
May 31, 2021

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented May 1, 2021

This PR has currently only a failing test and needs the implementation for the actual fix

fixes #282

@gr2m gr2m added Type: Bug Something isn't working as documented, or is being fixed typescript Relevant to TypeScript users only labels May 1, 2021
@gr2m gr2m self-assigned this May 22, 2021
@gr2m gr2m force-pushed the 282/typescript-fix-for-installation-authentication branch 2 times, most recently from b3f9557 to 8d1a37f Compare May 28, 2021 00:40
gr2m added a commit to octokit/auth-oauth-app.js that referenced this pull request May 29, 2021
gr2m added a commit to octokit/auth-oauth-app.js that referenced this pull request May 31, 2021
@gr2m gr2m changed the title fix(typescript): installation authentication type 🚧 fix(typescript): installation authentication type May 31, 2021
@gr2m gr2m force-pushed the 282/typescript-fix-for-installation-authentication branch from d3eb82d to 92e467d Compare May 31, 2021 22:51
@gr2m gr2m changed the title 🚧 fix(typescript): installation authentication type fix(typescript): installation authentication type May 31, 2021
@gr2m gr2m merged commit 9537cb4 into master May 31, 2021
@gr2m gr2m deleted the 282/typescript-fix-for-installation-authentication branch May 31, 2021 22:54
@github-actions
Copy link
Contributor

🎉 This PR is included in version 3.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented, or is being fixed typescript Relevant to TypeScript users only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property 'token' does not exist on type 'Authentication'
1 participant