Property 'token' does not exist on type 'Authentication'

[jwenz723]

I am going to start out by saying I am a total typescript/javascript newb.

I am trying to create a github action using this @octokit/auth-app library. I am trying to authenticate to github using an installation ID. For some reason the typing isn't setup properly to allow access of the token property of the object that is returned after calling createAppAuth. I was able to resolve my issue by adding : any to cast to the generic any type so that properties can be referenced generically. But this doesn't seem like an ideal solution.

Here is my code that does not succeed:

const auth = createAppAuth(createAppAuthOptions);
const installation = await auth({
    installationId: installationId,
    type: "installation",
});
return installation.token;

This code results in the following error when compiling:

TS2339: Property 'token' does not exist on type 'Authentication'.
  Property 'token' does not exist on type 'AppAuthentication'.

Here is my successful code with the any type workaround:

const auth = createAppAuth(createAppAuthOptions);
const installation:any = await auth({
    installationId: installationId,
    type: "installation",
});
return installation.token;

Any suggestions on what I should be doing differently, or is this a bug?

[gr2m]

Something is indeed not working correctly, I was able to reproduce the problem with a TypeScript playground

I'm looking into it

[gr2m]

I am trying to create a github action using this @octokit/auth-app library

By the way I just did a live coding show where I created a GitHub action that authenticates as an app, it's using the App SDK octokit, maybe give that a try?

Here is more info on the show and links to the video: gr2m/helpdesk#1

[gr2m]

I started a PR with a failing test at #283. I'll look into fixing this the coming week. I think I'll have to rewrite the types, similar to how they work in @octokit/auth-oauth-app. If you feel like hacking on it this weekend, please go ahead, you can start out with the failing test I created and try to fix it

[github-actions]

🎉 This issue has been resolved in version 3.4.1 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀