Add ranges.any_gaps
#185
Merged
Add ranges.any_gaps
#185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To give us even more confidence that the order of the input ranges does not matter.
Peter554
force-pushed
the
ranges.any-gaps
branch
from
deebcde to
e927d82
Compare
Peter554
commented
Jan 13, 2025
| @@ -589,6 +589,17 @@ def test_timestamps_sorted(self, period): | |||
|
|
|||
|
|
|||
| class TestAnyOverlapping: | |||
| def test_does_not_modify_ranges(self): | |||
There was a problem hiding this comment.
This should probably have been part of #184
Peter554
commented
Jan 13, 2025
| @@ -624,6 +624,7 @@ def test_does_not_modify_ranges(self): | |||
| ) | |||
| def test_returns_true_if_and_ranges_overlap(self, ranges_): | |||
| assert ranges.any_overlapping(ranges_) | |||
| assert ranges.any_overlapping(reversed(ranges_)) | |||
There was a problem hiding this comment.
This should probably have been part of #184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
ranges.any_gapsutility function.This function is very simple - all work is delegated to a
RangeSet. So arguably this function is not needed at all. I think it's still a useful addition though, since this check is commonly used and this utility function makes it slightly clearer and less likely to make an error.A benchmark is added, however the existing implementation was found to be pretty optimal. I suggest leaving the benchmark to help guard against regressions (I'm interested to set up codespeed for this, see here).