Skip to content

Ppx: refuse match cases with only exception cases #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aantron merged 2 commits into from
Jun 12, 2018
Merged

Ppx: refuse match cases with only exception cases #597

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88f2b5d
Ppx: refuse match cases with only exception cases
raphael-proust Jun 8, 2018
a83962f
Run PPX expect tests on OCaml >= 4.04 only
aantron Jun 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/ppx/ppx_lwt.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,12 @@ let lwt_expression mapper exp attributes =
| {pc_lhs = [%pat? exception [%p? _]]; _} -> true
| _ -> false)
in
if cases = [] then
raise (Location.Error (
Location.errorf
~loc:exp.pexp_loc
"match%%lwt must contain at least one non-exception pattern."
));
let exns =
exns |> List.map (
function
Expand Down
2 changes: 2 additions & 0 deletions test/ppx_expect/cases/match_5.expect
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
File "match_5.ml", line 2, characters 2-81:
Error: match%lwt must contain at least one non-exception pattern.
3 changes: 3 additions & 0 deletions test/ppx_expect/cases/match_5.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
let _ =
match%lwt Lwt.return () with
| exception (Invalid_argument _) -> Lwt.return 0