Ppx: refuse match cases with only exception cases#597
Merged
Conversation
Collaborator
|
Thanks @raphael-proust! I think we can skip the full breaking-change treatment for this PR :) For testing, we could add the ability to skip expect tests conditionally to the expect test framework. I'll push something into this PR tomorrow. |
Collaborator
|
Looking at the output, it may also be good enough to remove "Error: " prefixes from lines. |
Collaborator
|
Thanks @raphael-proust, and @cyberhuman for finding and reporting the issue. For the expect tests, I decided to restrict them to OCaml >= 4.04. We were already restricted to >= 4.03 before that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #596
I guess this technically counts as a breaking change just in case someone was using the behaviour (even though it was incompatible with ocaml's).