Skip to content

Conversation

@Octachron
Copy link
Member

This PR adds the opam package for the newly release OCaml 5.4.0 compiler:
More precisely, it adds the core compiler package

ocaml-compiler.5.4.0

and its two variants

ocaml-base-compiler.5.4.0
ocaml-variants.5.4.0+options

completed by the system version

ocaml-system.5.4.0

Simultaneously, this PR moves the dev package

ocaml-variants.5.4.0+trunk to ocaml-variants.5.4.1+trunk

and adds the necessary metapackage

ocaml.5.4.1

As last time, I have also included the two related packages

ocaml-src.5.4.0
ocaml-manual.5.4.0

@Octachron
Copy link
Member Author

The lint and test failures seem to be the usual "the compiler is not a completely regular package".

@mseri
Copy link
Member

mseri commented Oct 9, 2025

Thanks

@mseri mseri merged commit c603e59 into ocaml:master Oct 9, 2025
2 of 3 checks passed
@shonfeder
Copy link
Member

Congratulations and thank you for the release!

Why it is necessary to remove the previous trunk version, as done when moving ``packages/ocaml-variants/ocaml-variants.5.4.0+trunk/opamtopackages/ocaml-variants/ocaml-variants.5.4.1+trunk/opam`?

I ask because, the effect of this renaming is to cause the other trunk version to vanish from the registry, and that can break CI (needlessly, AFAICT).

shonfeder added a commit to shonfeder/dune that referenced this pull request Oct 11, 2025
Update the CI workflows to track the current major version trunk and
latest release.

As per ocaml/opam-repository#28683
shonfeder added a commit to shonfeder/dune that referenced this pull request Oct 11, 2025
Update the CI workflows to track the current major version trunk and
latest release.

As per ocaml/opam-repository#28683

Signed-off-by: Shon Feder <[email protected]>
shonfeder added a commit to shonfeder/dune that referenced this pull request Oct 11, 2025
Update the CI workflows to track the current major version trunk and
use the latest release in the build matrix, when tests are not run.

We cannot currently udate to 5.4 for the matrix used to run tests, but
some of the test dependencies don't support it.

As per ocaml/opam-repository#28683

Signed-off-by: Shon Feder <[email protected]>
shonfeder added a commit to shonfeder/dune that referenced this pull request Oct 11, 2025
Update the CI workflows to track the current major version trunk and
use the latest release in the build matrix, when tests are not run.

We cannot currently udate to 5.4 for the matrix used to run tests, but
some of the test dependencies don't support it.

As per ocaml/opam-repository#28683

Signed-off-by: Shon Feder <[email protected]>
shonfeder added a commit to ocaml/dune that referenced this pull request Oct 11, 2025
Update the CI workflows to track the current major version trunk and
use the latest release in the build matrix, when tests are not run.

We cannot currently udate to 5.4 for the matrix used to run tests, but
some of the test dependencies don't support it.

As per ocaml/opam-repository#28683

Signed-off-by: Shon Feder <[email protected]>
Sudha247 pushed a commit to Sudha247/dune that referenced this pull request Oct 13, 2025
Update the CI workflows to track the current major version trunk and
use the latest release in the build matrix, when tests are not run.

We cannot currently udate to 5.4 for the matrix used to run tests, but
some of the test dependencies don't support it.

As per ocaml/opam-repository#28683

Signed-off-by: Shon Feder <[email protected]>
@dra27
Copy link
Member

dra27 commented Oct 29, 2025

I ask because, the effect of this renaming is to cause the other trunk version to vanish from the registry, and that can break CI (needlessly, AFAICT).

As soon as the version was bumped in the OCaml branch (cf. ocaml/ocaml@75661f9) the ocaml-variants.5.4.0+trunk ceased to be installable, so there's no value in keeping the old package. We used to keep them because macOS's default patch couldn't cope with the opam update process when files were deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants