Fix problem with exceptions and type extensions in extended opens #1100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to issue ocaml#1066, which was partially fixed by ocaml#1082. This PR sorts the remaining two instances of the problem: exceptions and type extensions. Fixes ocaml#1095
trefis
approved these changes
Apr 12, 2024
Julow
approved these changes
Apr 15, 2024
| :: extract_signature_type_items vis rest | ||
|
|
||
| | Sig_typext (id, constr, _, Exported) :: rest -> | ||
| | Sig_typext (id, constr, _, vis') :: rest when vis=vis'-> |
Collaborator
There was a problem hiding this comment.
This looks correct but I would be more confident if this function was written in a way that makes use of exhaustive patterns. I can have a try at it separately.
jonludlam
added a commit
to jonludlam/opam-repository
that referenced
this pull request
Apr 29, 2024
CHANGES: ### Added - OCaml 5.2.0 compatibility (@Octachron, ocaml/odoc#1094, ocaml/odoc#1112) ### Fixed - Fix issues ocaml/odoc#1066 and ocaml/odoc#1095 with extended opens (@jonludlam, ocaml/odoc#1082, ocaml/odoc#1100)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to issue #1066, which was partially fixed by #1082. This PR sorts the remaining two instances of the problem: exceptions and type extensions.
Fixes #1095