Basic support for OCaml 5.2.0 #1094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Octachron
commented
Mar 21, 2024
| #if OCAML_VERSION >= (4,8,0) | ||
| #if OCAML_VERSION >= (5,2,0) | ||
| (let paths = Load_path.get_paths () in | ||
| List.filter (fun s -> s <> "") (paths.visible @ paths.hidden)) |
Member
Author
There was a problem hiding this comment.
This is the conservative version, it is possible that keeping just paths.visible would be better for odoc.
Collaborator
There was a problem hiding this comment.
Apparently, those function are only used in an old .md test, so anything is fine.
18 tasks
panglesd
approved these changes
Mar 22, 2024
Collaborator
panglesd
left a comment
panglesd
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR!
| #if OCAML_VERSION >= (4,8,0) | ||
| #if OCAML_VERSION >= (5,2,0) | ||
| (let paths = Load_path.get_paths () in | ||
| List.filter (fun s -> s <> "") (paths.visible @ paths.hidden)) |
Collaborator
There was a problem hiding this comment.
Apparently, those function are only used in an old .md test, so anything is fine.
panglesd
added a commit
to Octachron/odoc
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Paul-Elliot <[email protected]>
- Typedtree changes - Shape request API changes - Shape uid map changes - Basic support for open in types - Unit_info changes for typemod
Signed-off-by: Paul-Elliot <[email protected]>
jonludlam
added a commit
to jonludlam/opam-repository
that referenced
this pull request
Apr 29, 2024
CHANGES: ### Added - OCaml 5.2.0 compatibility (@Octachron, ocaml/odoc#1094, ocaml/odoc#1112) ### Fixed - Fix issues ocaml/odoc#1066 and ocaml/odoc#1095 with extended opens (@jonludlam, ocaml/odoc#1082, ocaml/odoc#1100)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the minimal changes for supporting OCaml 5.2, without taking advantages of any of the new shape features in OCaml 5.2.0 .
Another aspect that should probably be improved later on is the support for
opens in type expressions: the present PR is only traversing the open while it could be useful to keep track of those when generating the documentation: