refactor: Make CLI return lock dir path as Path.Source.t
#12505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
approved these changes
Sep 26, 2025
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Leonidas-from-XIV
force-pushed
the
lock-dirs-source
branch
from
4ac526a to
2226eab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factored out of #12394, this PR makes
Pkg_common.lock_dirs_of_workspacereturn aPath.Source.tagain. As the workspace definition is always aPath.Source.t, the CLI always refers to source paths and in #12394 it has proven to be a more sensible API.Converting a source path to a path is fairly trivial, converting the other way requires pattern matching and handling invalid cases, so restricting the type here is most likely an improvement overall.