Rollback dune file formatting change in 3.20.0 #12245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolás Ojeda Bär <[email protected]>
nojb
force-pushed
the
rollback_dune_formatting_change
branch
from
36e9c08 to
79c9e69
Compare
Collaborator
Author
It's here: |
maiste
approved these changes
Aug 21, 2025
Collaborator
maiste
left a comment
maiste
left a comment
There was a problem hiding this comment.
Thanks! I missed it in the list of files.
nojb
added a commit
to nojb/dune
that referenced
this pull request
Aug 21, 2025
Signed-off-by: Nicolás Ojeda Bär <[email protected]>
nojb
added a commit
that referenced
this pull request
Aug 22, 2025
Signed-off-by: Nicolás Ojeda Bär <[email protected]>
maiste
pushed a commit
to maiste/dune
that referenced
this pull request
Aug 25, 2025
Signed-off-by: Nicolás Ojeda Bär <[email protected]>
maiste
pushed a commit
to maiste/dune
that referenced
this pull request
Aug 25, 2025
Signed-off-by: Nicolás Ojeda Bär <[email protected]>
maiste
added a commit
that referenced
this pull request
Aug 25, 2025
* fix: rollback dune file formatting change in 3.20.0 (#12245) * Forgot Changes entry for #12245 (#12249) * chore: apply format Co-authored-by: Nicolás Ojeda Bär <[email protected]>
maiste
added a commit
to maiste/opam-repository
that referenced
this pull request
Aug 25, 2025
CHANGES: ### Fixed - Fix `runtest-js` mistakenly depending on `byte` (fixes ocaml/dune#12243, ocaml/dune#12242, @vouillon and @Alizter) - Fix the interpretation of paths in `dune runtest` when running from within a subdirectory. (ocaml/dune#12251, fixes ocaml/dune#12250, @Alizter) ### Changed - Revert formatting change introduced in 3.20.0 making long lists in s-expressions fill the line instead of formatting them in a vertical way (ocaml/dune#12245, reverts ocaml/dune#10892, @nojb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formatting change introduced in 3.20.0 (see #10892) has resulted in a number of complaints because of its unversioned nature (it does not depend on the version of the Dune language of the file being formatted). After discussion with @Alizter mainly we think that it may be a good idea to revert this change until we have a good versioning story.
The point of this PR is to have a patch ready in case we decide to do so in time for 3.20.1.