test: make sure runtest_alias works properly #12242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vouillon
force-pushed
the
tests-js
branch
2 times, most recently
from
9908556 to
6f70700
Compare
Signed-off-by: Jérôme Vouillon <[email protected]>
Collaborator
|
I've promoted the test output and am working on a fix. |
Collaborator
|
I've pushed a fix. Instead of |
Signed-off-by: Ali Caglayan <[email protected]>
Collaborator
|
@maiste This probably should go in 3.21.1. |
rgrinberg
approved these changes
Aug 21, 2025
Member
Author
|
@Alizter Thanks! |
Collaborator
|
@Alizter I suggest that we wait a bit before doing EDIT: considering the other changes, we will do the release fast. |
13 tasks
maiste
added a commit
that referenced
this pull request
Aug 25, 2025
* test: make sure runtest_alias works properly * fix(jsoo): runtest-js alias now depends on runtest-js-name for (tests) Co-authored-by: Jérôme Vouillon <[email protected]> Co-authored-by: Ali Caglayan <[email protected]>
maiste
added a commit
to maiste/opam-repository
that referenced
this pull request
Aug 25, 2025
CHANGES: ### Fixed - Fix `runtest-js` mistakenly depending on `byte` (fixes ocaml/dune#12243, ocaml/dune#12242, @vouillon and @Alizter) - Fix the interpretation of paths in `dune runtest` when running from within a subdirectory. (ocaml/dune#12251, fixes ocaml/dune#12250, @Alizter) ### Changed - Revert formatting change introduced in 3.20.0 making long lists in s-expressions fill the line instead of formatting them in a vertical way (ocaml/dune#12245, reverts ocaml/dune#10892, @nojb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.