Skip to content

Conversation

@Fil
Copy link
Contributor

@Fil Fil commented Dec 23, 2021

@Fil Fil requested a review from mbostock December 23, 2021 21:45
@mbostock
Copy link
Member

I don’t think we would notice if the hexadecimal values wouldn’t match. I was thinking of a visual test? E.g., if these are snapshot tests, then we can look at the SVG visually and see if it matches the expectations. Though, it’d be awkward to have many variations of each color scheme.

@Fil
Copy link
Contributor Author

Fil commented Dec 23, 2021

True. This is a non-regression test after I did a visual control, by looking at the (forthcoming) schemes cheatsheet—which is how I discovered the bug.

@mbostock
Copy link
Member

My point was that these tests would not reveal a bug, only a change, so I’d rather have visual tests—I’d rather be able to see the colors. I can put something together.

@mbostock mbostock mentioned this pull request Dec 31, 2021
@mbostock
Copy link
Member

Closing in favor of #637 (and #638).

@mbostock mbostock closed this Dec 31, 2021
@Fil Fil deleted the fil/scheme-tests branch June 7, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants