Skip to content

fix buylrd #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2021
Merged

fix buylrd #632

merged 1 commit into from
Dec 23, 2021

Conversation

@Fil
Copy link
Contributor

@Fil Fil commented Dec 23, 2021

before/after:

Capture d’écran 2021-12-23 à 18 32 12

Capture d’écran 2021-12-23 à 18 32 23

@Fil Fil added the bug Something isn’t working label Dec 23, 2021
@Fil Fil requested review from mbostock and mkfreeman December 23, 2021 17:33
mbostock
mbostock approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Good catch.

Might be worth adding a few more tests if you have a moment.

@Fil Fil merged commit 0081ee8 into main Dec 23, 2021
@Fil Fil deleted the fil/fix-buylrd-scheme branch December 23, 2021 18:17
@Fil Fil mentioned this pull request Dec 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbostock mbostock mbostock approved these changes

@mkfreeman mkfreeman Awaiting requested review from mkfreeman

Assignees

No one assigned

Labels

bug Something isn’t working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Fil @mbostock