Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geo + tip: true #1744

Closed
wants to merge 1 commit into from
Closed

geo + tip: true #1744

wants to merge 1 commit into from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Jul 10, 2023

This changes the derivation of a tip mark when there is only a geometry channel (typically, the geo mark) by:

Demo: https://observablehq.com/@fil/geo-tip-true-1744

fixes #1742
closes #1743

cc: @yurivish

@Fil Fil marked this pull request as ready for review July 10, 2023 08:22
- fix collapsing bug (#1742)
- compute a centroid if there is a geometry channel but no x and y channels (#1743)
@Fil
Copy link
Contributor Author

Fil commented Jul 10, 2023

closing, I'm going to separate the bug fix and the proposed new feature

@Fil Fil closed this Jul 10, 2023
@Fil Fil deleted the fil/geo-tip branch August 15, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plot.geo with tip: true should use Plot.centroid Plot.geo with tip: true collapses the chart
1 participant