Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plot.geo with tip: true should use Plot.centroid #1743

Closed
Fil opened this issue Jul 10, 2023 · 1 comment · Fixed by #2088
Closed

Plot.geo with tip: true should use Plot.centroid #1743

Fil opened this issue Jul 10, 2023 · 1 comment · Fixed by #2088
Labels
enhancement New feature or request

Comments

@Fil
Copy link
Contributor

Fil commented Jul 10, 2023

If there is no x and y channels (or maybe px and py ??), but we have a geometry channel, the tip: true option should derive these coordinates with Plot.centroid.
@Fil Fil added the enhancement New feature or request label Jul 10, 2023
Fil added a commit that referenced this issue Jul 10, 2023
@Fil
geo + tip: true
2a7a899 
- fix collapsing bug (#1742)
- compute a centroid if there is a geometry channel but no x and y channels (#1743)
@Fil Fil mentioned this issue Jul 10, 2023
Closed
Fil added a commit that referenced this issue Jul 10, 2023
@Fil
geo + tip: true
83424fe 
- fix collapsing bug (#1742)
- compute a centroid if there is a geometry channel but no x and y channels (#1743)
@Fil Fil mentioned this issue Jul 10, 2023
Closed
@Fil Fil mentioned this issue Aug 14, 2023
Open
@Fil
Copy link
Contributor Author

Fil commented Oct 9, 2023

Would be nice to have "properties" as a default channel, maybe—though this is an object, so we'd need a specific formatter too (?).

This was referenced Jun 15, 2024
Merged
Closed
@abdulrahman305 abdulrahman305 mentioned this issue Aug 28, 2024
Merged
@FreeMason9224 FreeMason9224 mentioned this issue Oct 4, 2024
Open
@NotDutchy NotDutchy mentioned this issue Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

promote geometry to x and y for tip observablehq/plot
geo + tip: true observablehq/plot
1 participant
@Fil