Skip to content

Fix int overflow when the struct column has null value #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhztheplayer merged 2 commits into from
Feb 10, 2023
Merged

Fix int overflow when the struct column has null value #199

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5441b25
fix the int overflow
Feb 9, 2023
394378c
add comments
Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion java/c/src/main/java/org/apache/arrow/c/ArrayImporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,10 @@ private List<ArrowBuf> importBuffers(ArrowArray.Snapshot snapshot) {
if (bufferPtr != NULL) {
// TODO(roee88): an API for getting the size for each buffer is not yet
// available
buffer = new ArrowBuf(referenceManager, null, Integer.MAX_VALUE, bufferPtr);
// When the buffer is StructVector#validityBuffer, the length need
// to set Integer.MAX_VALUE / 8. Otherwise it will throw int overflow
// exception when calling StructVector#getValidityBufferValueCapacity().
buffer = new ArrowBuf(referenceManager, null, Integer.MAX_VALUE / 8, bufferPtr);
}
result.add(buffer);
}
Expand Down