Skip to content

Conversation

@JkSelf
Copy link

@JkSelf JkSelf commented Feb 9, 2023

When struct has null value, the bitBuffer will identify rows with null values and not be nullptr in ArrowArray in native side. In Java side, if the bitBuffer is not null, it will be initialized to newBuffer with Integer.MAX_VALUE capacity here when import buffers. Then when calling the StructVector.setValueCount() method, the getValidityBufferValueCapacity will throw int overflow issue.

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@JkSelf
Copy link
Author

JkSelf commented Feb 9, 2023

@zhztheplayer
Please help to review!

@zhztheplayer
Copy link
Collaborator

zhztheplayer commented Feb 9, 2023

@JkSelf Would you like to add some comments around the code?

And it should be noted that in apache#14506 Apache Arrow possibly fixed this issue, I am not sure.

@JkSelf
Copy link
Author

JkSelf commented Feb 10, 2023

@JkSelf Would you like to add some comments around the code?

And it should be noted that in apache#14506 Apache Arrow possibly fixed this issue, I am not sure.
Yes. It seems this issue has been fixed and we can remove this change after upgrading arrow.

@zhztheplayer zhztheplayer merged commit 87ea816 into oap-project:backend_velox_main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants