Skip to content

Website: add sections with transactions #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 15 commits into
base: develop
Choose a base branch
from
Draft

Website: add sections with transactions #1553

wants to merge 15 commits into from

Conversation

@dannywillems
Copy link
Member

@dannywillems dannywillems commented Oct 16, 2025

No description provided.

@dannywillems dannywillems marked this pull request as draft October 16, 2025 11:55
@github-actions
Copy link

github-actions bot commented Oct 16, 2025 •
edited
Loading

OCaml Reference Validation Results

Repository: https://github.com/MinaProtocol/mina.git
Branch: compatible
Status: ❌ Validation failed

Click to see full validation output 
Checking OCaml references against https://github.com/MinaProtocol/mina.git (branch: compatible)
Fetching current commit from compatible...
Current OCaml commit: b4d740af3a2f57ced08ed0aecff76b67b2b59155

Validating references...
========================
✓ VALID: ledger/src/account/account.rs -> src/lib/mina_base/account.ml L:201-224
  ⚠ STALE COMMIT: fc6be4c58091c761f827c858229c2edf9519e941 (current: b4d740af3a2f57ced08ed0aecff76b67b2b59155)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2285-2285
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4d740af3a2f57ced08ed0aecff76b67b2b59155)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2351-2356
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4d740af3a2f57ced08ed0aecff76b67b2b59155)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2407
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4d740af3a2f57ced08ed0aecff76b67b2b59155)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:9-51
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4d740af3a2f57ced08ed0aecff76b67b2b59155)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:452-454
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4d740af3a2f57ced08ed0aecff76b67b2b59155)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/with_status.ml L:6-10
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4d740af3a2f57ced08ed0aecff76b67b2b59155)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:76-80
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4d740af3a2f57ced08ed0aecff76b67b2b59155)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:68-69
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4d740af3a2f57ced08ed0aecff76b67b2b59155)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/coinbase.ml L:17-21
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4d740af3a2f57ced08ed0aecff76b67b2b59155)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/transaction/transaction.ml L:8-11
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4d740af3a2f57ced08ed0aecff76b67b2b59155)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:34-48
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4d740af3a2f57ced08ed0aecff76b67b2b59155)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/stake_delegation.ml L:11-13
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4d740af3a2f57ced08ed0aecff76b67b2b59155)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:179-181
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4d740af3a2f57ced08ed0aecff76b67b2b59155)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:239-243
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4d740af3a2f57ced08ed0aecff76b67b2b59155)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:352-362
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4d740af3a2f57ced08ed0aecff76b67b2b59155)
❌ INVALID: ledger/src/scan_state/transaction_logic/transaction_partially_applied.rs
   Code at L:2197-2210 differs between commit bfd1009abdbee78979ff0343cc73a3480e862f58 and current branch
   Referenced: https://github.com/MinaProtocol/mina/blob/bfd1009abdbee78979ff0343cc73a3480e862f58/src/lib/transaction_logic/mina_transaction_logic.ml#L2197-L2210
   Current:    https://github.com/MinaProtocol/mina/blob/compatible/src/lib/transaction_logic/mina_transaction_logic.ml#L2197-L2210
✓ VALID: ledger/src/scan_state/transaction_logic/transaction_partially_applied.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2074-2178
  ⚠ STALE COMMIT: 0063f0196d046d9d2fc8af0cea76ff30f51b49b7 (current: b4d740af3a2f57ced08ed0aecff76b67b2b59155)
❌ INVALID: ledger/src/scan_state/transaction_logic/transaction_partially_applied.rs
   Code at L:607 differs between commit 2ee6e004ba8c6a0541056076aab22ea162f7eb3a and current branch
   Referenced: https://github.com/MinaProtocol/mina/blob/2ee6e004ba8c6a0541056076aab22ea162f7eb3a/src/lib/transaction_logic/mina_transaction_logic.ml#L607-L607
   Current:    https://github.com/MinaProtocol/mina/blob/compatible/src/lib/transaction_logic/mina_transaction_logic.ml#L607-L607
❌ INVALID: ledger/src/scan_state/transaction_logic/transaction_partially_applied.rs
   Code at L:1852 differs between commit 2ee6e004ba8c6a0541056076aab22ea162f7eb3a and current branch
   Referenced: https://github.com/MinaProtocol/mina/blob/2ee6e004ba8c6a0541056076aab22ea162f7eb3a/src/lib/transaction_logic/mina_transaction_logic.ml#L1852-L1852
   Current:    https://github.com/MinaProtocol/mina/blob/compatible/src/lib/transaction_logic/mina_transaction_logic.ml#L1852-L1852

Summary
=======
Total references found: 20
Valid references: 17
Invalid references: 3
Stale commits: 17

❌ Validation failed: 3 invalid reference(s) found

@github-actions
Copy link

github-actions bot commented Oct 16, 2025 •
edited
Loading

⚠️ Code Reference Verification Failed

The documentation contains code references that do not match the current state of the codebase on the develop branch.

Issues Found

  • website/docs/developers/transactions/coinbase.md:42 - CODE_REFERENCE comment specifies L452-L473 but GitHub URL has different line range
  • website/docs/developers/transactions/coinbase.md:144 - Code reference to ledger/src/scan_state/transaction_logic/transaction_partially_applied.rs#L559-L561 differs from GitHub (develop branch). The referenced code may have been modified locally but not yet merged to develop.
  • website/docs/developers/transactions/payments.md:100 - Line range L1341-L1343 exceeds file length (1295 lines) in ledger/src/scan_state/transaction_logic/transaction_partially_applied.rs

Action Required

The code referenced in the documentation must be merged to develop before documentation can be added/modified.

Please follow this workflow:

  1. Merge the code changes to develop first (this PR or a separate code PR)
  2. Create a follow-up PR with the documentation updates that reference the merged code
  3. The verification will pass once the code is available on develop

See the documentation guidelines for more information about the two-PR workflow.

@dannywillems dannywillems force-pushed the dw/website-add-transactions-doc branch from 7480a18 to ba0d52c Compare October 16, 2025 15:15
@dannywillems dannywillems force-pushed the dw/website-add-transactions-doc branch from ba0d52c to 5804e60 Compare October 16, 2025 15:17
@dannywillems dannywillems mentioned this pull request Oct 30, 2025
Merged
4 tasks
dannywillems added a commit that referenced this pull request Oct 31, 2025
@dannywillems
Update OCaml references in transaction_partially_applied.rs
7235c53 
Updates OCaml references from URL format to the new structured format
with commit hash and verification date for:
- FailureCollection impl
- apply_coinbase function (with expanded documentation)
- sub_account_creation_fee function

Changes ported from mina-rust PR #1553.
@dannywillems dannywillems mentioned this pull request Oct 31, 2025
Open
dannywillems added a commit that referenced this pull request Oct 31, 2025
@dannywillems
Update OCaml references in transaction_partially_applied.rs
bc5b5d8 
Updates OCaml references from URL format to the new structured format
with commit hash and verification date for:
- FailureCollection impl
- apply_coinbase function (with expanded documentation)
- sub_account_creation_fee function

Changes ported from mina-rust PR #1553.
dannywillems added a commit that referenced this pull request Oct 31, 2025
@dannywillems
Add fee transfers documentation and update sidebar
44b5998 
Adds comprehensive fee transfer transaction documentation including:
- Overview and transaction structure
- Single vs. double transfer examples
- Token constraints and validation
- Account creation handling
- Test coverage references

Updates sidebar to include fee-transfers.md under Transaction types.

Changes ported from mina-rust PR #1553.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

Rust node
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dannywillems