-
Notifications
You must be signed in to change notification settings - Fork 41
Add tests for account creation in transaction logic #1581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds new test cases for account creation scenarios: - test_apply_payment_creates_receiver_account: Tests payment transactions that automatically create receiver accounts, verifying that the account creation fee is deducted from the payment amount. - test_apply_coinbase_with_fee_transfer_creates_account: Tests coinbase transactions with fee transfers to nonexistent accounts, verifying account creation and fee deduction. These tests ensure correct handling of account creation fees during the first pass of two-phase transaction application.
OCaml Reference Validation ResultsRepository: https://github.com/MinaProtocol/mina.git Click to see full validation output |
✓ Code Reference Verification PassedAll code references in the documentation have been verified successfully! Total references checked: 1 The documentation is in sync with the codebase on the |
richardpringle
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #1553
Summary
Adds new test cases for account creation scenarios in transaction logic:
test_apply_payment_creates_receiver_account: Tests payment transactionsthat automatically create receiver accounts, verifying that the account
creation fee is deducted from the payment amount.
test_apply_coinbase_with_fee_transfer_creates_account: Tests coinbasetransactions with fee transfers to nonexistent accounts, verifying account
creation and fee deduction.
These tests ensure correct handling of account creation fees during the first
pass of two-phase transaction application.
Test plan
cargo test --test test_transaction_logic_first_passcargo test --test test_transaction_logic_first_pass_coinbase --releaseSource: Tests ported from #1553