-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I updated your ice plugin to the best of my ability for TinyMCE v 4 #76
base: master
Are you sure you want to change the base?
Conversation
Thanks @catsgotmytongue. Did you need to make any changes to any of the src/*.js ice files? |
The only updates I made had to do with tinymce plugin.js( in 3.5.8 it was
|
Updated to allow actions to disable/enable buttons using TinyMCE4. Also added a couple menu items for accept and reject.
without this if you turn off track changes then the editor does not process deletes and backspaces
enables default backspace and delete key when ICE is not tracking
Updated plugin to allow disable/enable buttons
Hi, But when the subject was ..." from the demo you have provided.
When I tried to debug, the deleteContents function from ice.js is not called as expected. Any advice/suggestion is welcome. |
…tinymce 4 folder structure. seems like not a whole lot of compatibility differences between 3.5 and 4 (so far)
Test the merge of CatsGotMyTonge's fork of Ice (TinyMCE v4 changes) with the upstream master (NYTimes)
hi @catsgotmytongue and @Parivalavan I've used @catsgotmytongue's most recent code and pulled in the most recent upstream changes into #105, if you want to take a look. |
Update to latest NYTimes/ice's master.
I am new. Please advise where to download ice plugin for Tinymce4.0 Jquery version. I could not plug-in the ice-master in TinyMCE JQM 4.0 |
@catsgotmytongue - can you please help me and give some more details. I downloaded your changes as a zip but I'm not sure what to place into the tinymce plugins folder. If I try to place the ice and icesearchreplace from what you have within tinymce/plugins I get uncaught reference errors. Can you please explain what we need to do to get this working. PS: THANK SO MUCH! |
wow it's been a while since I worked on it so I'd have to get my head I'll try to look into it this tomorrow or friday. |
Thanks so much Curt. Basically we are using the latest tinymce…and I followed what you mentioned but I’m not sure what files to place anywhere. It seems when I do as the documentation on nytimes says it is looking for a ice.min.js plugin..which doesn’t exist. So I landed on your branch copy where you mentioned you got this thing to work specifically for tinymce. I would love it if you could please help me set this up…as I do not want to reinvent the wheel of tracking changes. Thanks again Curt. Jon From: Curt Mullin [mailto:notifications@github.com] wow it's been a while since I worked on it so I'd have to get my head I'll try to look into it this tomorrow or friday. On Wed, Oct 29, 2014 at 10:05 AM, JonH notifications@github.com wrote:
— |
@jhermiz Can you send me (catsgotmytongue@gmail.com) a zip of the files you're having trouble with ? I'm having trouble pinning down what the issue is, maybe I can figure it out and then send them back to you and maybe update my github branch once I figure out what the issue is. |
Curt, I also tried to make this work so, it would be very helpful if you could pass along anything that you find. Thank you for doing this. Tom On Nov 3, 2014, at 9:57 PM, Curt Mullin notifications@github.com wrote:
|
Hi! I too would very much like to get thos workkng with TinyMCe4. I'm having some challenges with the downloaded version og Tinymce thus am using the CDN. Would be nice if ice was configurable as a local plugin, but that is maybe outside ice's control? |
Sorry about the spellings. Big thumbs, small phone. ;) |
Is anyone having trouble using the backspace to delete text while track changes is on? |
Yes I discovered such a behaviour in Firefox. But it was a few month ago and the project paused since then. Didn't had the time for further investigations. |
I've tried two forks, both @catsgotmytongue's and @TinderBox's, but neither allow backspace. I'm thinking of switching to CKEditor which has a working ice plugin. |
Hi, First of all thanks a lot and appreciate the work of ICE plugin. We are using TinyMce 4.1.7 version in our project. We are having requirement of integrating Track changes capabilities in tinymce editor for review purpose. We check the demo and sample provided on GitHub. We are able to integrate it and it works fine. However the tinymce.js in that sample is of version 4.0b1. I have attached the error screen. I will be grateful if you can Please help us out in resolving this issue. Also Please suggest if we are missing anything. Or steps. |
@BharatDPatel simple copy plugin.js (in the plugins/ice directory) and rename it to plugin.min.js. |
I thought you would appreciate this as I changed it for the app I'm currently working on and it should be a working plugin for tinymce4 now.
Btw, Thanks for the awesome plugin it has saved me tons of work and I really appreciate that.