-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for TinyMCE 4.x.x (Removes support from 3.x.x) #105
Conversation
Updated to allow actions to disable/enable buttons using TinyMCE4. Also added a couple menu items for accept and reject.
without this if you turn off track changes then the editor does not process deletes and backspaces
enables default backspace and delete key when ICE is not tracking
Updated plugin to allow disable/enable buttons
…tinymce 4 folder structure. seems like not a whole lot of compatibility differences between 3.5 and 4 (so far)
Test the merge of CatsGotMyTonge's fork of Ice (TinyMCE v4 changes) with the upstream master (NYTimes)
Great work! Is anyone using this in production? It's hard to integration test against tinymce, and getting ice to adapt to new versions of tinymce has always been a huge pain. |
we don't, but we might in the near future. |
It would be nice to see this request merged, as WordPress ships the version 4 of TinyMCE since WordPress version 3.9. So contribution for WP support depends on this. |
https://github.com/TinderBox is using this in production. :-) |
@NullVoxPopuli Did you test this plugin tested on 4.3.x TinyMce? |
@itmilos We are on 4.3.6 and continue to use this plugin. We have had to make a few tweaks to core tinymce over time but it has held up really well. |
Cleaning up my PRs. If this work is still desired, feel free to cherry-pick |
Only thing left (to my knowledge)