Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for TinyMCE 4.x.x (Removes support from 3.x.x) #105

Closed
wants to merge 20 commits into from

Conversation

NullVoxPopuli
Copy link

  • Pull upstream (nytimes) master
  • Remove TinyMCE 3.5 related code
  • Changed folder structure of plugins to match that of TinyMCE 4.x.x

Only thing left (to my knowledge)

  • When building, the plugin files are named plugin.js instead of plugin.min.js (any help on that would be awesome)

unknown and others added 20 commits June 28, 2013 11:44
Updated to allow actions to disable/enable buttons using TinyMCE4.

Also added a couple menu items for accept and reject.
without this if you turn off track changes then the editor does not process deletes and backspaces
enables default backspace and delete key when ICE is not tracking
Updated plugin to allow disable/enable buttons
…tinymce 4 folder structure. seems like not a whole lot of compatibility differences between 3.5 and 4 (so far)
Test the merge of CatsGotMyTonge's fork of Ice (TinyMCE v4 changes) with the upstream master (NYTimes)
@delambo
Copy link
Member

delambo commented Apr 6, 2014

Great work! Is anyone using this in production? It's hard to integration test against tinymce, and getting ice to adapt to new versions of tinymce has always been a huge pain.

@johanneswilm
Copy link
Contributor

we don't, but we might in the near future.

@dnaber-de
Copy link

It would be nice to see this request merged, as WordPress ships the version 4 of TinyMCE since WordPress version 3.9. So contribution for WP support depends on this.

@NullVoxPopuli
Copy link
Author

https://github.com/TinderBox is using this in production. :-)

@andrew-kzoo
Copy link

I'm hopeful about this plugin. Is it still being used and/or under active development at @nytimes? I'd love to make use of it with @tinymce 4.x.x and to contribute fixes and updates. Thank you!

@itmilos
Copy link

itmilos commented May 23, 2016

@NullVoxPopuli Did you test this plugin tested on 4.3.x TinyMce?

@NullVoxPopuli
Copy link
Author

@itmilos, I'm not sure. @jheth might be able to answer though?

@jheth
Copy link

jheth commented May 23, 2016

@itmilos We are on 4.3.6 and continue to use this plugin. We have had to make a few tweaks to core tinymce over time but it has held up really well.

@NullVoxPopuli
Copy link
Author

Cleaning up my PRs. If this work is still desired, feel free to cherry-pick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants