Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #2528

Closed
wants to merge 1 commit into from
Closed

Update README.md #2528

wants to merge 1 commit into from

Conversation

billyhunt
Copy link

zsh is the default shell for mac now, so we should write the nvm config to that.

@billyhunt
Update README.md
b30abf0 
zsh is the default shell for mac now, so we should write the nvm config to that.
ljharb
ljharb requested changes Jun 29, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not what this does. The install script is written in bash and will ONLY work in bash, and that should have no impact on what profile files are installed into.

Additionally, nvm is used on many posix systems, not just Macs.

@ljharb
Copy link
Member

ljharb commented Jun 29, 2021

Duplicate of #2417. Duplicate of #2300.

@ljharb ljharb closed this Jun 29, 2021
@ljharb ljharb added the installing nvm Problems installing nvm itself label Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb requested changes

Assignees
No one assigned
Labels
installing nvm Problems installing nvm itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billyhunt @ljharb