mac big sur uses zsh

[8secz-johndpope]

No description provided.

[ljharb]

This won't actually work, because the install script is written to only work in bash.

It must always be used with | bash, regardless of what your current shell is.

[8secz-johndpope]

it does seem to correctly target the updates necessary for .zshrc file though.

[ljharb]

In that case, I'd prefer something more generic like | $SHELL, and then we'd have to rewrite the install script to work in POSIX.

What does your echo $SHELL say prior to running the install script?

[8secz-johndpope]

echo $SHELL
/bin/zsh

[ljharb]

In that case, I'd expect #2260 to address it a bit?

[8secz-johndpope]

I'd say all the scripts are fine - just readme seems misdirectional.

having a link that sends them off to another page maybe fine.
zsh
https://gist.github.com/steelcowboy/1d7ac8aed8e7b6a275aa1d35ac43cd1a

dash
https://gist.github.com/steelcowboy/1af21c23cac3208b9dc77676475e65d3

ksh
https://gist.github.com/steelcowboy/5b62b7ac44c7e425c504a86ba511d1dc

[ljharb]

If in fact it already works in all supported shells, I'd be fine changing the | bash line to something like | "${SHELL:-bash}, and also adding test runs to CI for those use cases.

[hinell]

The installation script explicitly states that it uses bash (shebang line), so piping it into zsh makes little sense, so does adding it to the docs. As I stated in related PR Switching the shell to something other than bash risks breaking backward compatibility.

nvm/install.sh

Lines 1 to 2 in 21c0c05

	#!/usr/bin/env bash

[sladyn98]

The installation script explicitly states that it uses bash (shebang line), so piping it into zsh makes little sense, so does adding it to the docs. As I stated in related PR Switching the shell to something other than bash risks breaking backward compatibility.

@ljharb in view of this, would we like to close this ? or would we still want to pursue a PR in which we pipe it with other shells, although it might risk the backward compatibility

[ljharb]

Yes, I think the proper solution is to improve the install script's shell detection behavior.