Python 3: Fix error when fetching JAVA text ranges - #9951
Merged
Conversation
Collaborator
Author
|
@fernando-jose-silva: Here is a try build. Could you please have a test? |
Contributor
|
I can have a look at it, too.
What do i need to test?
|
Collaborator
Author
|
Just a text field. |
|
@LeonarddeR |
feerrenrut
approved these changes
Jul 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9939
Summary of the issue:
When fetching java text ranges, NVDA now throws a character buffer at getAccessibleTextRange (see commit 15d8374). This no longer matches the ctypes prototype applied to the function.
Description of how this pull request fixes the issue:
Told ctypes that it should now expect a pointer to c_char instead of _wchar.
Testing performed:
t.b.d.
Known issues with pull request:
NOne
Change log entry:
None