Installer GUI/Python 3: check if install comparison method returns None or not - #9924
Merged
feerrenrut merged 1 commit intoJul 15, 2019
Conversation
…s not None. Re nvaccess#9923. Comparison function found in installer can return an integer (-1, 0, 1) or None. Because of this, when comparing the return value from installer GUI, it assumed None was an integer when in fact in Python 3, it is a different type.
LeonarddeR
approved these changes
Jul 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9923
Summary of the issue:
Installer GUI does not catch type error when attempting to install NVDA from scratch.
Description of how this pull request fixes the issue:
Make sure installer's install comparison function's return value is not None before checking if an upgrade or a warning dialog is shown when trying to update or install NVDA from scratch.
Testing performed:
Tested inside Windows 10 Version 1903 sandbox.
Known issues with pull request:
None
Change log entry:
None